This revision was automatically updated to reflect the committed changes.
Closed by commit rL289686: [DebugInfo] Restore test case for long double
constants. (authored by dgross).
Changed prior to commit:
https://reviews.llvm.org/D27597?vs=81321&id=81423#toc
Repository:
rL LLVM
https://revi
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D27597#621618, @dgross wrote:
> So would a Python equivalent of the Perl be acceptable? I think this is an
> academic question -- better to explicitly test m
dgross updated this revision to Diff 81321.
dgross added a comment.
Incorporate code review comments.
- Use %clang_cc1 not %clang
- Rather than trying to determine long double size for target, compile and
check multiple times, and only check behavior of long double for known targets
https://re
dgross added a comment.
In https://reviews.llvm.org/D27597#621596, @probinson wrote:
> As dblaikie said in email, probably better to make this X86-specific; if
> long-double varies by OS you can put in a specific triple.
I think with this approach I'd want two test cases that are identical exc
probinson added a comment.
As dblaikie said in email, probably better to make this X86-specific; if
long-double varies by OS you can put in a specific triple.
FTR we don't rely on Perl being available everywhere, anything that does this
kind of scripty stuff uses Python.
Com
On Mon, Dec 12, 2016 at 1:11 PM David Gross wrote:
> I looked at what's supported by "requires", and couldn't find anything
> appropriate.
>
> The problem is that I want the test to be sensitive to the size of long
> double -- either no greater than 64 bits, or greater than 64 bits. It does
> no
I looked at what's supported by "requires", and couldn't find anything
appropriate.
The problem is that I want the test to be sensitive to the size of long
double -- either no greater than 64 bits, or greater than 64 bits. It does
not seem practical to list all platforms (so I suspect your "xfail
While it's possible to do arbitrary script things - we prefer nto to to
ensure the tests are portable. (we have some custom implementations of
common unix utilities for portability of those).
In this case, can you xfail this on platforms that don't have the feature
you want? rather than trying to
dgross added a comment.
I don't know exactly what the RUN syntax supported by lit is. What I've done
here looks complex, but it does work for Linux. What about other platforms?
Is there some better way of writing a test case where the checks to be done by
FileCheck depend on some property of
dgross created this revision.
dgross added reviewers: cfe-commits, probinson.
https://reviews.llvm.org/D27549 (partial fix for PR26619) emits a constant
value in the debug
metadata for a floating-point static const that does not exceed 64
bits in size. Whether or not a long double exceeds 64 bit
10 matches
Mail list logo