Eugene.Zelenko added a comment.
Yes, IWYU is useful tool, but please note that it's not ideal, so will be good
idea to check proposed changes manually.
You could build IWYU in-tree with Clang or Clang extra tools.
https://reviews.llvm.org/D27655
_
michael.sharpe added a comment.
In https://reviews.llvm.org/D27655#619307, @Eugene.Zelenko wrote:
> Did you enable analysis of headers in Clang-tidy?
I had not, thanks for the tip.
Comment at: lib/Lex/ModuleMap.cpp:35
#if defined(LLVM_ON_UNIX)
-#include
+#include
#endif
michael.sharpe updated this revision to Diff 81179.
michael.sharpe added a comment.
- Address review comments, check headers for C style headers
https://reviews.llvm.org/D27655
Files:
include/clang/Analysis/Analyses/ThreadSafetyTIL.h
include/clang/Basic/Linkage.h
include/clang/Basic/Targe
Eugene.Zelenko added a comment.
Did you enable analysis of headers in Clang-tidy?
Comment at: lib/Frontend/CompilerInstance.cpp:51
#include
-#include
+#include
#include
Will be good idea to run Clang-format or sort headers manually.
Com
michael.sharpe created this revision.
michael.sharpe added a reviewer: rsmith.
michael.sharpe added a subscriber: cfe-commits.
Herald added subscribers: JDevlieghere, klimek.
https://reviews.llvm.org/D27655
Files:
lib/CodeGen/CGOpenCLRuntime.cpp
lib/Driver/Types.cpp
lib/Frontend/CodeGenOpti
