alexfh added a comment.
One late comment.
Comment at: clang-tools-extra/trunk/clang-tidy/utils/ExprSequence.cpp:154-155
+const Stmt *ExprSequence::resolveSyntheticStmt(const Stmt *S) const {
+ if (SyntheticStmtSourceMap.count(S))
+return SyntheticStmtSourceMap.lookup(S);
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290489: [clang-tidy] refactor ExprSequence out of
use-after-move check (authored by mnbvmar).
Changed prior to commit:
https://reviews.llvm.org/D27700?vs=81732=82440#toc
Repository:
rL LLVM
mnbvmar marked 9 inline comments as done.
mnbvmar added inline comments.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:18
using namespace clang::ast_matchers;
+using namespace clang::tidy::utils;
+
mboehme wrote:
> Prazek wrote:
> > Prazek wrote:
> > > I
mnbvmar updated this revision to Diff 81732.
mnbvmar marked 2 inline comments as done.
mnbvmar added a comment.
Minor changes, according to the request.
https://reviews.llvm.org/D27700
Files:
clang-tidy/misc/UseAfterMoveCheck.cpp
clang-tidy/utils/CMakeLists.txt
mboehme accepted this revision.
mboehme added a comment.
This revision is now accepted and ready to land.
LG apart from minor comments by others and me
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:18
using namespace clang::ast_matchers;
+using namespace
Prazek added inline comments.
Comment at: clang-tidy/utils/ExprSequence.cpp:52
+
+bool isDescendantOrEqual(const Stmt *Descendant, const Stmt *Ancestor,
+ ASTContext *Context) {
staronj wrote:
> Shouldn't isDescendantOrEqual be static or
staronj added inline comments.
Comment at: clang-tidy/utils/ExprSequence.cpp:52
+
+bool isDescendantOrEqual(const Stmt *Descendant, const Stmt *Ancestor,
+ ASTContext *Context) {
Shouldn't isDescendantOrEqual be static or in inline
alexfh added inline comments.
Comment at: clang-tidy/utils/ExprSequence.cpp:154
+return SyntheticStmtSourceMap.lookup(S);
+ else
+return S;
Prazek wrote:
> alexfh wrote:
> > nit: No `else` after return, please.
> Not sure if he should change it in this
Prazek added inline comments.
Comment at: clang-tidy/utils/ExprSequence.cpp:154
+return SyntheticStmtSourceMap.lookup(S);
+ else
+return S;
alexfh wrote:
> nit: No `else` after return, please.
Not sure if he should change it in this patch - it is just
Prazek added inline comments.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:18
using namespace clang::ast_matchers;
+using namespace clang::tidy::utils;
+
Prazek wrote:
> I don't think it is required
ok I guess I am wrong
https://reviews.llvm.org/D27700
Prazek added inline comments.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:18
using namespace clang::ast_matchers;
+using namespace clang::tidy::utils;
+
I don't think it is required
Comment at: clang-tidy/utils/ExprSequence.cpp:180-182
11 matches
Mail list logo
