[PATCH] D27748: [clang-tidy] Suggest including if necessary in type-promotion-in-math-fn-check.

This revision was automatically updated to reflect the committed changes. jlebar marked an inline comment as done. Closed by commit rL289637: [clang-tidy] Suggest including if necessary in type-promotion-in-math… (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D27748?vs

[PATCH] D27748: [clang-tidy] Suggest including if necessary in type-promotion-in-math-fn-check.

jlebar marked 2 inline comments as done. jlebar added a comment. Thank you for the review, @alexfh. I will commit with these changes. Comment at: clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:198 +Result.Context->getSourceManager().getFil

[PATCH] D27748: [clang-tidy] Suggest including if necessary in type-promotion-in-math-fn-check.

alexfh added a comment. LG with a couple of nits. https://reviews.llvm.org/D27748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27748: [clang-tidy] Suggest including if necessary in type-promotion-in-math-fn-check.

alexfh accepted this revision. alexfh added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:187 - diag(Call->getExprLoc(), "call to '%0' promotes float to double") - <<

[PATCH] D27748: [clang-tidy] Suggest including if necessary in type-promotion-in-math-fn-check.

jlebar created this revision. jlebar added a reviewer: alexfh. jlebar added a subscriber: cfe-commits. Herald added a subscriber: JDevlieghere. https://reviews.llvm.org/D27748 Files: clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp clang-tools-extra/clang-tidy/performan