cameron314 added a comment.
The `IsValid = true` line coincidentally fixes a tangentially related bug --
see https://reviews.llvm.org/D20338 (in which I tried to introduce the same fix
almost a year earlier, but nobody accepted the review). I guess I have to
maintain the test for that case out
erikjv closed this revision.
erikjv added a comment.
Committed as r298905.
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
erikjv updated this revision to Diff 93221.
erikjv added a comment.
Added a test for the specific scenario, and added asserts for validity of UFEs
returned by getVirtualFile.
https://reviews.llvm.org/D27810
Files:
lib/Basic/FileManager.cpp
unittests/Basic/FileManagerTest.cpp
Index: unitte
bruno added a comment.
Please attach a testcase!
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erikjv added a comment.
@klimek no, it's a 1 line fix. The rest was the previous version of the patch.
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
Is the diff view on phab broken, or am I missing something? I only see a single
line of diff now, and don't see a way to change the diff.
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
bkramer added a comment.
I assume this is fine but I don't really understand what's going on. A test
case would be great.
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
erikjv added a comment.
@kfunk yes and yes, so @bkramer or @klimek : ping?
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kfunk added a comment.
@erikjv Ready for review? Does this reliably fix
https://bugreports.qt.io/browse/QTCREATORBUG-15449?
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
erikjv updated this revision to Diff 88874.
erikjv retitled this revision from "Normalize all filenames before searching
FileManager caches" to "FileManager: mark virtual file entries as valid
entries".
erikjv edited the summary of this revision.
https://reviews.llvm.org/D27810
Files:
lib/Bas
11 matches
Mail list logo