[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

This revision was automatically updated to reflect the committed changes. Closed by commit rL290883: [clang-tidy] Handle constructors in performance-unnecessary-value-param (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D28022?vs=82443=82865#toc Repository:

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

malcolm.parsons updated this revision to Diff 82443. malcolm.parsons added a comment. Add double backticks. https://reviews.llvm.org/D28022 Files: clang-tidy/performance/UnnecessaryValueParamCheck.cpp clang-tidy/utils/DeclRefExprUtils.cpp clang-tidy/utils/DeclRefExprUtils.h

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

aaron.ballman added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:96 - // Do not trigger on non-const value parameters when: - // 1. they are in a constructor definition since they can likely trigger - //modernize-pass-by-value which

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

alexfh added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:96 - // Do not trigger on non-const value parameters when: - // 1. they are in a constructor definition since they can likely trigger - //modernize-pass-by-value which will

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

aaron.ballman added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:96 - // Do not trigger on non-const value parameters when: - // 1. they are in a constructor definition since they can likely trigger - //modernize-pass-by-value which

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

malcolm.parsons added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:96 - // Do not trigger on non-const value parameters when: - // 1. they are in a constructor definition since they can likely trigger - //modernize-pass-by-value

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

malcolm.parsons updated this revision to Diff 82239. malcolm.parsons added a comment. Move hasBody check into matcher. The matcher checks the function is a definition. https://reviews.llvm.org/D28022 Files: clang-tidy/performance/UnnecessaryValueParamCheck.cpp

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

aaron.ballman added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:96 - // Do not trigger on non-const value parameters when: - // 1. they are in a constructor definition since they can likely trigger - //modernize-pass-by-value which

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

malcolm.parsons added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:96 - // Do not trigger on non-const value parameters when: - // 1. they are in a constructor definition since they can likely trigger - //modernize-pass-by-value

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

malcolm.parsons added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:96 - // Do not trigger on non-const value parameters when: - // 1. they are in a constructor definition since they can likely trigger - //modernize-pass-by-value

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

aaron.ballman added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:96 - // Do not trigger on non-const value parameters when: - // 1. they are in a constructor definition since they can likely trigger - //modernize-pass-by-value which

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

malcolm.parsons updated this revision to Diff 82237. malcolm.parsons marked 3 inline comments as done. malcolm.parsons added a comment. Add some variables. Improve comments. https://reviews.llvm.org/D28022 Files: clang-tidy/performance/UnnecessaryValueParamCheck.cpp

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:114 if (AllDeclRefExprs.size() == 1 && -

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, flx, alexfh. malcolm.parsons added a subscriber: cfe-commits. Herald added a subscriber: JDevlieghere. modernize-pass-by-value doesn't warn about value parameters that cannot be moved, so