This revision was automatically updated to reflect the committed changes.
jlebar marked 2 inline comments as done.
Closed by commit rL290717: [ADT] Delete RefCountedBaseVPTR. (authored by
jlebar).
Changed prior to commit:
https://reviews.llvm.org/D28162?vs=82681&id=82685#toc
Repository:
rL L
jlebar marked an inline comment as done.
jlebar added inline comments.
Comment at: llvm/unittests/ADT/IntrusiveRefCntPtrTest.cpp:14-37
+struct VirtualRefCounted : public llvm::RefCountedBase {
+ VirtualRefCounted() { ++NumInstances; }
+ VirtualRefCounted(const VirtualRefCounted
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good - thanks for the cleanup!
Comment at: llvm/unittests/ADT/IntrusiveRefCntPtrTest.cpp:14-37
+struct VirtualRefCounted : public llvm::RefCountedBase {
+ VirtualR
jlebar created this revision.
jlebar added reviewers: compnerd, dblaikie.
jlebar added subscribers: llvm-commits, cfe-commits.
Herald added subscribers: mgorny, klimek.
This class is unnecessary.
Its comment indicated that it was a compile error to allocate an
instance of a class that inherits fr
