ioeric updated this revision to Diff 83051.
ioeric marked an inline comment as done.
ioeric added a comment.
- fix a nit.
https://reviews.llvm.org/D28282
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index:
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with some nits.
Would be clearer to elaborate more descriptions in the commit message. Looks
like the patch actually resolves newline character "\n" rather than
whitespace...
alexshap added a comment.
thx, LGTM
https://reviews.llvm.org/D28282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:563
+ // Create a replacement merely for retrieving file path and start offset.
+ const auto R = createReplacement(Start, Start, "", *Result.SourceManager);
MoveNamespace MoveNs;
ioeric updated this revision to Diff 83024.
ioeric marked an inline comment as done.
ioeric added a comment.
- Get rid of hacky replacement.
https://reviews.llvm.org/D28282
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index:
alexshap added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:563
+ // Create a replacement merely for retrieving file path and start offset.
+ const auto R = createReplacement(Start, Start, "", *Result.SourceManager);
MoveNamespace MoveNs;
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
https://reviews.llvm.org/D28282
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
