This revision was automatically updated to reflect the committed changes.
Closed by commit rL297187: [analyzer] Fix crashes in CastToStruct checker for
undefined structs (authored by danielmarjamaki).
Changed prior to commit:
https://reviews.llvm.org/D28297?vs=89507&id=90900#toc
Repository:
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thanks. looks good.
https://reviews.llvm.org/D28297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
a.sidorin added a comment.
Looks like a right fix.
Comment at: lib/StaticAnalyzer/Checkers/CastToStructChecker.cpp:93
// Warn when there is widening cast.
unsigned ToWidth = Ctx.getTypeInfo(ToPointeeTy).Width;
NoQ wrote:
> I think we should move the
danielmarjamaki requested review of this revision.
danielmarjamaki added a comment.
I have updated the patch and want a new review.
https://reviews.llvm.org/D28297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
danielmarjamaki updated this revision to Diff 89507.
danielmarjamaki added a comment.
It was reported in the bugzilla report that my first fix did not fix all
crashes. A new example code was provided that triggered a new crash. I have
updated the patch so both crashes are fixed.
https://review
danielmarjamaki reopened this revision.
danielmarjamaki added a comment.
This revision is now accepted and ready to land.
I reverted the change because there were buildbot failures.
Repository:
rL LLVM
https://reviews.llvm.org/D28297
___
cfe-comm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295545: [analyzer] Fix crash in CastToStruct when there is
no record definition (authored by danielmarjamaki).
Changed prior to commit:
https://reviews.llvm.org/D28297?vs=83062&id=89019#toc
Repository:
zaks.anna added a comment.
Please, make sure future reviews go through cfg-dev list. See
http://llvm.org/docs/Phabricator.html.
Repository:
rL LLVM
https://reviews.llvm.org/D28297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I sometimes wish ASTContext methods just didn't crash :)
Oh well, let's just see if more problems show up.
Comment at: lib/StaticAnalyzer/Checkers/CastToStructChecker.cpp:93
danielmarjamaki added a comment.
In https://reviews.llvm.org/D28297#642523, @NoQ wrote:
> Looks good. I assume the crash is in `getTypeInfo()`; do you have any idea
> what are exact prerequisites for using this method? So that there were no
> more crashes here.
Yes. The crash happens during t
zaks.anna added a comment.
Please, subscribe cfe-commits list on the patches as described in
http://llvm.org/docs/Phabricator.html.
Thanks!
Anna
Repository:
rL LLVM
https://reviews.llvm.org/D28297
___
cfe-commits mailing list
cfe-commits@lists.
NoQ added a subscriber: zaks.anna.
NoQ added a comment.
Looks good. I assume the crash is in `getTypeInfo()`; do you have any idea what
are exact prerequisites for using this method? So that there were no more
crashes here.
Repository:
rL LLVM
https://reviews.llvm.org/D28297
danielmarjamaki created this revision.
danielmarjamaki added a reviewer: NoQ.
danielmarjamaki added a subscriber: cfe-commits.
danielmarjamaki set the repository for this revision to rL LLVM.
This fix the crash reported in https://llvm.org/bugs/show_bug.cgi?id=31173
Repository:
rL LLVM
https:
13 matches
Mail list logo