This revision was automatically updated to reflect the committed changes.
Closed by commit rL292617: [Frontend] The macro that describes the Objective-C
bool type should (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D28349?vs=83354=85143#toc
Repository:
rL LLVM
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D28349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D28349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
In https://reviews.llvm.org/D28349#636968, @doug.gregor wrote:
> The "!LangOpts.CPlusPlus" doesn't make sense to me. You're presumably
> defining this macro in C because the Objective-C runtime is usable from C,
> but that same logic applies to C++ code. It seems like
arphaman updated this revision to Diff 83354.
arphaman added a comment.
Set the macro unconditionally.
Repository:
rL LLVM
https://reviews.llvm.org/D28349
Files:
lib/Frontend/InitPreprocessor.cpp
test/Frontend/objc-bool-is-bool.m
Index: test/Frontend/objc-bool-is-bool.m
doug.gregor added a comment.
The "!LangOpts.CPlusPlus" doesn't make sense to me. You're presumably defining
this macro in C because the Objective-C runtime is usable from C, but that same
logic applies to C++ code. It seems like we should be defining this macro
unconditionally.
Repository:
arphaman created this revision.
arphaman added reviewers: doug.gregor, t.p.northover.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch defines __OBJC_BOOL_IS_BOOL for C code as well, since Objective-C's
BOOL can be also used by C
