[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added a comment. In D28462#1575262 , @sylvestre.ledru wrote: > @VelocityRa could you please add it to the release notes? > https://github.com/llvm-mirror/clang/blob/master/docs/ReleaseNotes.rst > I can commit the change if you need Yeah

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

sylvestre.ledru added a comment. @VelocityRa could you please add it to the release notes? https://github.com/llvm-mirror/clang/blob/master/docs/ReleaseNotes.rst I can commit the change if you need Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

sylvestre.ledru added a comment. Sure, done in r365445 thanks for your work! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 ___ cfe-commits mailing list

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

This revision was automatically updated to reflect the committed changes. Closed by commit rL364938: clang-format: Add new style option AlignConsecutiveMacros (authored by sammccall, committed by ). Herald added a project: LLVM. Changed prior to commit:

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

sammccall added a comment. It sounds like this is fairly low-risk (it's behind a flag that's off by default), has been approved, and we want it in clang-format 9, so I'm going to rebase and land it. I don't understand the patch in detail so if there is significant fallout I'll have to revert

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

LingDev added a comment. We need this feature as well, we are also waiting for it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

vit9696 added a comment. Could somebody commit it into 9.0? Quite a lot of people depend on this option including us. Since it got accepted I do not see a reason for this to get postponed any further. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

phosek added a comment. Would it be possible to land this change? Do you need help with landing it? We've been waiting for this for a long time and we would like to start using it now that it has been accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. @klimek responded via the mailing list http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190506/270976.html CHANGES SINCE LAST ACTION

Re: [PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

*From: *MyDeveloperDay via Phabricator *Date: *Fri, May 10, 2019 at 12:30 PM *To: * , , , < krasi...@google.com>, , *Cc: * , , , < marcosbe...@gmail.com>, , , < shua2...@gmail.com>, , , < vit9...@avp.su>, , , < mydeveloper...@gmail.com>, , < bderickson+llvm...@gmail.com>, , < vee...@veegee.org>,

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. When I spoke with one of the code owners, they seemed to have a problem accepting this review based on there not being a general description/understanding of how this algorithm works. Having said that, all of the "AlignToken" based functions

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

micah-s added a comment. @djasper @klimek @krasimir @sammccall @enyquist Can I trouble you for an update? In D28462#1492600 , @jkorous wrote: > Hi @VelocityRa, just FYI - it's considered fine to ping your reviewers once > per week here if you've

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

jkorous added a comment. Hi @VelocityRa, just FYI - it's considered fine to ping your reviewers once per week here if you've addressed their comments and there's no activity in the review. Sometimes people just get distracted by other things. CHANGES SINCE LAST ACTION

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa updated this revision to Diff 192694. VelocityRa marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:520 + + AlignMacroSequence(StartOfSequence, EndOfSequence, MinColumn, MaxColumn, + FoundMatchOnLine, AlignMacrosMatches, Changes); klimek wrote: > Why are we

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

klimek added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:520 + + AlignMacroSequence(StartOfSequence, EndOfSequence, MinColumn, MaxColumn, + FoundMatchOnLine, AlignMacrosMatches, Changes); Why are we calling

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa updated this revision to Diff 191891. VelocityRa added a comment. Right, how's that? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

klimek added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:482 + // containing any matching token to be aligned and located after such token. + auto AlignCurrentSequence = [&] { +if (StartOfSequence > 0 && StartOfSequence < EndOfSequence) {

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:500 +if (Changes[i].NewlinesBefore != 0) { + EndOfSequence = i; + // If there is a blank line, or if the last line didn't contain any klimek wrote: > VelocityRa wrote: >

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa updated this revision to Diff 191493. VelocityRa marked 13 inline comments as done. VelocityRa added a comment. Diff updated. Some comments about the inline changes, since the rest were trivial: - `AlignMacroSequence` was inlined - `AlignMacros` was after that - `AlignMacrosMatches`

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

klimek added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:436 +static void +AlignTokenSequenceAll(unsigned Start, unsigned End, unsigned Column, + F &, VelocityRa wrote: > klimek wrote: > > I don't think the 'All' postfix in

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa marked 11 inline comments as done. VelocityRa added a comment. Waiting for further feedback before pushing an update. Comment at: lib/Format/WhitespaceManager.cpp:436 +static void +AlignTokenSequenceAll(unsigned Start, unsigned End, unsigned Column, +

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

klimek added a comment. In D28462#1406716 , @jacob-keller wrote: > In regards to whether clang-format should support this feature, I think it's > pretty clear that a large number of users want it to. The tool already > supports formatting various other

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. > ClamAV recently started using clang-format. We published this blog post > about how we're using it: > https://blog.clamav.net/2019/02/clamav-adopts-clang-format.html One of the > things I called out in the blog post is that we really want this feature, and

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

micah-s added a comment. In D28462#1413332 , @MyDeveloperDay wrote: > Would you please consider logging your struct example from your blog at > https://bugs.llvm.org, I see a large number of people using clang format > on/off in github for this and

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

micah-s added a comment. In D28462#1412556 , @MyDeveloperDay wrote: > For those wishing to test the effectiveness of unlanded revisions like this > and to reduce the amount of time between Windows snapshot builds > (https://llvm.org/builds/), I have

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. In D28462#1407239 , @micah-s wrote: > ClamAV recently started using clang-format. We published this blog post > about how we're using it: > https://blog.clamav.net/2019/02/clamav-adopts-clang-format.html One of the >

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

micah-s added a comment. ClamAV recently started using clang-format. We published this blog post about how we're using it: https://blog.clamav.net/2019/02/clamav-adopts-clang-format.html One of the things I called out in the blog post is that we really want this feature, and presently we

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

jacob-keller added a comment. In regards to whether clang-format should support this feature, I think it's pretty clear that a large number of users want it to. The tool already supports formatting various other definitions in a similar manner, including variables and struct members. So I

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. > Yes, we are, and as you said, it needs a set of patches to learn the code > base enough to contribute, to build up trust. This is easiest when the code > base is currently under active development, but many people consider > clang-format "good enough" minus

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

klimek added a comment. In D28462#1405360 , @MyDeveloperDay wrote: > I'm not a code owner here but we seem to be lacking people who are either > available, able, willing or allowed to approve code reviews for some of the > code in the clang-tooling

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

klimek added a comment. In D28462#1405855 , @MyDeveloperDay wrote: > In D28462#1405711 , @klimek wrote: > > > In D28462#1405360 , > > @MyDeveloperDay wrote: > > > > > I'm

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. In D28462#1405711 , @klimek wrote: > In D28462#1405360 , @MyDeveloperDay > wrote: > > > I'm not a code owner here but we seem to be lacking people who are either > > available,

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. I'm not a code owner here but we seem to be lacking people who are either available, able, willing or allowed to approve code reviews for some of the code in the clang-tooling (not just clang format). The code owners do an extremely good job at doing a deep

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. @djasper and @klimek you both look relatively inactive in the last couple of weeks/month, is there anyone else who acts as a gate keeper for clang-format or can anyone add a LGTM? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

jacob-keller added a comment. Is there anything holding this up that could use help? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added a comment. In D28462#1376710 , @enyquist wrote: > Looks fine to me, although I confess I did not build and run it because I > don't have the time to set up the environment again, took a few hours last > time I built from scratch (side

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. Looks fine to me, although I confess I did not build and run it because I don't have the time to set up the environment again, took a few hours last time I built from scratch (side note, if there's an easy way to speed up llvm/clang compilation up I'd love to hear it

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. I checked this out and built this and it works really well. The thing I really like is that it helps to format Windows resource include files e.g. 'Resource.h' better than before. Which changes the current clang-formatted version #define

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa updated this revision to Diff 184010. VelocityRa added a comment. I extracted the logic of `AlignTokens` and `AlignTokenSequence` that aligning macros uses to the best of my ability. This new logic now resides in `AlignTokensAll` and `AlignTokenSequenceAll` (so that it may be

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

AlexAltea added a comment. My open-source project would heavily benefit from //clang-format//, but we require this proposed `AlignConsecutiveMacros` feature. I've placed a modest bounty of 50 USD for it. Since BountySource isn't compatible with Phabricator, I linked the bounty to an "external"

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. @smilewithani @lassi.niemisto @mewmew feel free to take a stab at it Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 ___ cfe-commits mailing list

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

smilewithani added a comment. In https://reviews.llvm.org/D28462#1257259, @mewmew wrote: > Any update on this? There are quite a few people who got excited about this > change and would like to start using it with clang-format. Same here! Repository: rL LLVM

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

mewmew added a comment. Any update on this? There are quite a few people who got excited about this change and would like to start using it with clang-format. Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

lassi.niemisto added a comment. My project team would also highly appreciate if this got implemented. Currently working around the issue by post-formatting the clang-formatted files with uncrustify and filtering it so that it only touches lines starting with #. Repository: rL LLVM

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

klimek added a comment. In https://reviews.llvm.org/D28462#1148732, @enyquist wrote: > @klimek having gotten that out of the way, I do occasionally drink too much > and have sudden urges to re-implement things from scratch. Close it if you > need to, since I can't commit to anything, but

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. @klimek having gotten that out of the way, I do occasionally drink too much and have sudden urges to re-implement things from scratch. Close it if you need to, since I can't commit to anything, but it it happens to be still open on one of those nights, who knows,

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

klimek added a comment. In https://reviews.llvm.org/D28462#1147019, @enyquist wrote: > @klimek fair point. To be honest, I've pretty much lost interest / momentum > on this feature, I very much doubt I will ever go back and re-implement from > scratch as you suggest. > Not meaning to sound

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. @klimek fair point. To be honest, I've pretty much lost interest / momentum on this feature, I very much doubt I will ever go back and re-implement from scratch as you suggest. Not meaning to sound rude, I just don't want to waste anyone's time who is waiting for this

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

RKeelan added a comment. My team is waiting for this feature, too. Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

tiena2cva added a comment. I am waiting for this feature. Any update? Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

klimek added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:438 + + AlignTokens(Style, + [&](const Change ) { I'm not sure whether we should use AlignTokens here, given that we pass in a parameter to basically skip all its

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

bartpeeters added a comment. We too would like this feature to be in the official release Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

TimF added a comment. In https://reviews.llvm.org/D28462#1064789, @enyquist wrote: > As far as I know, there are no updates required from me for this pull > request-- I rebased on the main trunk recently, and will do it again tonight > to be sure. So it should be compiling/working just fine. >

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. As far as I know, there are no updates required from me for this pull request-- I rebased on the main trunk recently, and will do it again tonight to be sure. So it should be compiling/working just fine. I believe it is just awaiting final approval from somebody.

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

markoshorro added a comment. This feature should have been merged time ago, any news? Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

elvinio added a comment. Any updates on this request? Eagerly waiting for this feature. Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. @dtzWill thanks for the suggestion, I have submitted this change to the weekly review corner. Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist updated this revision to Diff 135744. enyquist added a comment. Rebased on current master. No functional changes, just a minor conflict where a variable got re-named Repository: rL LLVM https://reviews.llvm.org/D28462 Files: docs/ClangFormatStyleOptions.rst

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

jorisa added a comment. This is also a highly anticipated feature for us! Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

kromanova added subscribers: kromanova, alexfh. kromanova added a comment. We have a request for this feature in clang-format in Sony. Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

dtzWill added a comment. Ping! Is this stalling on reviewer attention? If so, please submit to LLVM Weekly's review corner (assuming it works with current LLVM), see http://llvmweekly.org/reviewcorner for details. Repository: rL LLVM https://reviews.llvm.org/D28462

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

jzr added a comment. I happen to need this functionality as well. What's the progress? Is there anything I can do to help it along? Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

jzr added a comment. On a related note, would it be difficult to add support for custom spacing between the macro name and definition? In the HelenOS project, we have definitions aligned two spaces after the longest name. Repository: rL LLVM https://reviews.llvm.org/D28462

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

sylvestre.ledru added a comment. Any news on this? cc @djasper Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. Gaaah. I'm so sorry. I wrote that last comment months ago and never submitted. No wonder you guys weren't responding. Comment at: lib/Format/WhitespaceManager.cpp:470 // definitions. return C.Tok->is(TT_StartOfName)

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:431 + + // Special case for AlignTokens: for all other alignment cases, + // the current sequence is ended when a comma or a scope change djasper wrote: >

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

djasper added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:431 + + // Special case for AlignTokens: for all other alignment cases, + // the current sequence is ended when a comma or a scope change enyquist wrote: >

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist updated this revision to Diff 96333. enyquist marked an inline comment as done. enyquist added a comment. Addressed comments Repository: rL LLVM https://reviews.llvm.org/D28462 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist marked 2 inline comments as done. enyquist added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:413 + + while (Param && !Param->is(tok::l_paren)) { +if (!Param->is(tok::identifier) && !Param->is(tok::comma)) djasper wrote: > enyquist

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

djasper added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:413 + + while (Param && !Param->is(tok::l_paren)) { +if (!Param->is(tok::identifier) && !Param->is(tok::comma)) enyquist wrote: > djasper wrote: > > enyquist wrote: > > > djasper

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist updated this revision to Diff 95680. enyquist added a comment. Rebased on latest Repository: rL LLVM https://reviews.llvm.org/D28462 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/WhitespaceManager.cpp

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist updated this revision to Diff 93341. enyquist added a comment. Apologies-- forgot to update a comment Repository: rL LLVM https://reviews.llvm.org/D28462 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist updated this revision to Diff 9. enyquist marked 2 inline comments as done. Repository: rL LLVM https://reviews.llvm.org/D28462 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/WhitespaceManager.cpp

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:413 + + while (Param && !Param->is(tok::l_paren)) { +if (!Param->is(tok::identifier) && !Param->is(tok::comma)) djasper wrote: > enyquist wrote: > > djasper wrote: > > > I think

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

djasper added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:413 + + while (Param && !Param->is(tok::l_paren)) { +if (!Param->is(tok::identifier) && !Param->is(tok::comma)) enyquist wrote: > djasper wrote: > > I think you should be able to

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist updated this revision to Diff 93204. enyquist marked 3 inline comments as done. enyquist added a comment. Addressed all comments, except for the one about FormatToken.MatchingParen (see reply comment) https://reviews.llvm.org/D28462 Files: docs/ClangFormatStyleOptions.rst

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist marked 8 inline comments as done. enyquist added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:287 SmallVector , +bool ConsiderScope, bool ConsiderCommas,

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

djasper added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:287 SmallVector , +bool ConsiderScope, bool ConsiderCommas, unsigned StartAt) {

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist updated this revision to Diff 93092. enyquist added a comment. Option implemented completely in WhitespaceManager.cpp, so no overhead if the option isn't used. Also some minor style fixes. Repository: rL LLVM https://reviews.llvm.org/D28462 Files:

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. @sylvestre.ledru No, unfortunately not. My apologies, I've been taken up with work mostly. I will make a marked attempt to do it this weekend :) Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

sylvestre.ledru added a comment. Any progress on this? Thanks Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. Thanks :) I should get a chance to return to this next week. Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

djasper added a comment. Sorry, it took a bit longer, but I have now submitted those changes in r293616. Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added inline comments. Comment at: Format/FormatToken.h:148 + /// \brief Whether the token is the final token in the identifier of a PP + // macro. This will be either 1) the identifier token following the 'define' djasper wrote: > This adds a lot

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist created this revision. enyquist added reviewers: djasper, sylvestre.ledru. enyquist added a subscriber: cfe-commits. enyquist set the repository for this revision to rL LLVM. enyquist added a project: clang-c. Herald added a subscriber: klimek. This option behaves similarly to