mclow.lists closed this revision.
mclow.lists added a comment.
Landed as r291741, r291742 and r293154.
https://reviews.llvm.org/D28473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists accepted this revision.
mclow.lists added a reviewer: mclow.lists.
mclow.lists added a comment.
This revision is now accepted and ready to land.
revision 291741
https://reviews.llvm.org/D28473
___
cfe-commits mailing list
cfe-commits@lis
rsmith added inline comments.
Comment at: include/__string:248
+#if _LIBCPP_STD_VER <= 14
+return (const char_type*) memchr(__s, to_int_type(__a), __n);
+#else
We can add another builtin to Clang to support this case if you'd like.
(There's also a way to ge
mclow.lists added inline comments.
Comment at: include/__string:261
+
+// inline _LIBCPP_CONSTEXPR_AFTER_CXX14
+// int
I will remove this block before committing.
https://reviews.llvm.org/D28473
___
cfe-commits ma
mclow.lists created this revision.
mclow.lists added reviewers: EricWF, rsmith.
mclow.lists added a subscriber: cfe-commits.
Make `assign`/`length`/`find`/`compare` for `std::char_traits` constexpr.
This makes using `string_view`s at compile time easier.
Use the compiler intrinsics when availabl
