[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-12 Thread Katya Romanova via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL291876: [DOXYGEN] Documentation for the newly added x86 intrinsics. (authored by kromanova). Changed prior to commit: https://reviews.llvm.org/D28503?vs=84038&id=84200#toc Repository: rL LLVM https:

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-12 Thread Asaf Badouh via Phabricator via cfe-commits
AsafBadouh added a comment. LGTM Comment at: emmintrin.h:1607 +/// +/// This intrinsic corresponds to the VMOVSD / MOVSD instruction. +/// kromanova wrote: > RKSimon wrote: > > kromanova wrote: > > > kromanova wrote: > > > > kromanova wrote: > > > > > probins

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-11 Thread Katya Romanova via Phabricator via cfe-commits
kromanova updated this revision to Diff 84038. kromanova added a comment. Changed the instruction name from VMOVSD to VMOVQ for _mm_loadu_si64 Repository: rL LLVM https://reviews.llvm.org/D28503 Files: avxintrin.h emmintrin.h mmintrin.h pmmintrin.h xmmintrin.h Index: xmmintrin.h

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-11 Thread Katya Romanova via Phabricator via cfe-commits
kromanova added inline comments. Comment at: emmintrin.h:1607 +/// +/// This intrinsic corresponds to the VMOVSD / MOVSD instruction. +/// RKSimon wrote: > kromanova wrote: > > kromanova wrote: > > > kromanova wrote: > > > > probinson wrote: > > > > > should th

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-11 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: emmintrin.h:1607 +/// +/// This intrinsic corresponds to the VMOVSD / MOVSD instruction. +/// kromanova wrote: > kromanova wrote: > > kromanova wrote: > > > probinson wrote: > > > > should this be VMOVQ/MOVQ instead? >

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-11 Thread Katya Romanova via Phabricator via cfe-commits
kromanova added inline comments. Comment at: emmintrin.h:1607 +/// +/// This intrinsic corresponds to the VMOVSD / MOVSD instruction. +/// probinson wrote: > should this be VMOVQ/MOVQ instead? Probably yes. Let me know if you have a different opinion. If I us

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-11 Thread Paul Robinson via Phabricator via cfe-commits
probinson added inline comments. Comment at: emmintrin.h:1607 +/// +/// This intrinsic corresponds to the VMOVSD / MOVSD instruction. +/// should this be VMOVQ/MOVQ instead? Repository: rL LLVM https://reviews.llvm.org/D28503 ___

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-10 Thread Albert Gutowski via Phabricator via cfe-commits
agutowski added a comment. For my part, LGTM. Repository: rL LLVM https://reviews.llvm.org/D28503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-10 Thread michael zuckerman via Phabricator via cfe-commits
m_zuckerman added a comment. For my intrinsics ( _mm256_cvtsd_f64, _mm256_cvtsi256_si32 and _mm256_cvtss_f32) - ** LGTM**. Repository: rL LLVM https://reviews.llvm.org/D28503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l