[PATCH] D28620: Guard __gnuc_va_list typedef

2017-01-23 Thread Paul Robinson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL292819: Guard __gnuc_va_list typedef. (authored by probinson). Changed prior to commit: https://reviews.llvm.org/D28620?vs=84151=85430#toc Repository: rL LLVM https://reviews.llvm.org/D28620

[PATCH] D28620: Guard __gnuc_va_list typedef

2017-01-21 Thread Yaron Keren via Phabricator via cfe-commits
yaron.keren accepted this revision. yaron.keren added a comment. This revision is now accepted and ready to land. LGTM, matches the code in libstdc++ stdarg,h. You can remove the 'hack' comment in line 46, __GNUC_VA_LIST is just a standard include guard for the typedef.

[PATCH] D28620: Guard __gnuc_va_list typedef

2017-01-17 Thread Sean Fertile via Phabricator via cfe-commits
sfertile added a comment. I think the fix/test looks good, but someone with more experience than me should review it before accepting it https://reviews.llvm.org/D28620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28620: Guard __gnuc_va_list typedef

2017-01-12 Thread Paul Robinson via Phabricator via cfe-commits
probinson created this revision. probinson added a reviewer: yaron.keren. probinson added a subscriber: cfe-commits. https://reviews.llvm.org/D28620 Files: lib/Headers/stdarg.h test/Headers/stdarg-gnuc_va_list.c Index: test/Headers/stdarg-gnuc_va_list.c