This revision was automatically updated to reflect the committed changes.
Closed by commit rL301532: [ObjC] Disallow vector parameters and return values
in Objective-C methods (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D28670?vs=95099&id=96892#toc
Repository:
r
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks Alex. LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D28670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D28670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman updated this revision to Diff 95099.
arphaman marked an inline comment as done.
arphaman added a comment.
Add an assertion as requested by Bruno.
Repository:
rL LLVM
https://reviews.llvm.org/D28670
Files:
include/clang/AST/DeclBase.h
include/clang/Basic/DiagnosticSemaKinds.td
bruno added inline comments.
Comment at: lib/Sema/SemaDeclObjC.cpp:4309
+ const ObjCMethodDecl *Method) {
+ SourceLocation Loc;
+ QualType T;
Maybe add an assert for `Triple.getArch() == llvm::Triple::x86)` here?
Repos
arphaman added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D28670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman updated this revision to Diff 90832.
arphaman marked an inline comment as done.
arphaman added a comment.
Add a test for non-ext vector type
Repository:
rL LLVM
https://reviews.llvm.org/D28670
Files:
include/clang/AST/DeclBase.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/A
arphaman added inline comments.
Comment at: lib/Sema/SemaDeclObjC.cpp:4312
+ for (const ParmVarDecl *P : Method->parameters()) {
+if (P->getType()->isVectorType()) {
+ Loc = P->getLocStart();
bruno wrote:
> Assuming objc/c++ can pass/return these, the c
bruno added a comment.
Hi Alex,
Comment at: lib/Sema/SemaDeclObjC.cpp:4312
+ for (const ParmVarDecl *P : Method->parameters()) {
+if (P->getType()->isVectorType()) {
+ Loc = P->getLocStart();
Assuming objc/c++ can pass/return these, the current check
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D28670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman updated this revision to Diff 84564.
arphaman marked an inline comment as done.
arphaman added a comment.
Use better diagnostic message as suggested by Erik
Repository:
rL LLVM
https://reviews.llvm.org/D28670
Files:
include/clang/AST/DeclBase.h
include/clang/Basic/DiagnosticSema
arphaman added inline comments.
Comment at: lib/Sema/SemaDeclObjC.cpp:4337
+ VersionTuple MethodVersion = Method->getVersionIntroduced();
+ if (SemaRef.getASTContext().getTargetInfo().getPlatformMinVersion() >=
+ AcceptedInVersion &&
erik.pilkington wr
erik.pilkington added a comment.
Hi Alex, thanks for CCing me!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1157
+def err_objc_method_unsupported_param_ret_type : Error<
+ "%0 %select{parameter|return value}1 is unsupported for this target">;
+
s/ret
arphaman created this revision.
arphaman added reviewers: gparker42, mehdi_amini, erik.pilkington.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch adds a new error that disallows methods that have parameters/return
values with a vecto
14 matches
Mail list logo