This revision was automatically updated to reflect the committed changes.
Closed by commit rL298912: [ASTMatchers] add typeAliasTemplateDecl matcher.
(authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D28671?vs=93228&id=93230#toc
Repository:
rL LLVM
https://reviews.llvm
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D28671
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
ioeric added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:191
+const internal::VariadicDynCastAllOfMatcher
+typeAliasTemplateDecl;
+
aaron.ballman wrote:
> Be sure to add this to Registry.cpp so that it can be used as a dynamic
> matc
ioeric updated this revision to Diff 93228.
ioeric marked an inline comment as done.
ioeric added a comment.
- Register the matcher to Dynamic.
https://reviews.llvm.org/D28671
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:191
+const internal::VariadicDynCastAllOfMatcher
+typeAliasTemplateDecl;
+
Be sure to add this to Registry.cpp so that it c
ioeric added a comment.
PTAL
https://reviews.llvm.org/D28671
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 93227.
ioeric added a comment.
- generate html for the new matcher.
https://reviews.llvm.org/D28671
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersNodeTest.cpp
Index: unittests/ASTMat
hokein added a comment.
You also need to add a new generated document
(`docs/LibASTMatchersReference.html`) for that. Please run
`clang/docs/tools/dump_ast_matchers.py`, it will do the stuff for you.
https://reviews.llvm.org/D28671
___
cfe-commits
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D28671
Files:
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersNodeTest.cpp
Index: unittests/ASTMatchers
