This revision was automatically updated to reflect the committed changes.
Closed by commit rL299340: Fixes for modernize-use-using check: (authored by
krystynka).
Changed prior to commit:
https://reviews.llvm.org/D29262?vs=93797=93804#toc
Repository:
rL LLVM
https://reviews.llvm.org/D29262
krystyna updated this revision to Diff 93797.
krystyna marked 2 inline comments as done.
https://reviews.llvm.org/D29262
Files:
clang-tidy/modernize/UseUsingCheck.cpp
clang-tidy/modernize/UseUsingCheck.h
test/clang-tidy/modernize-use-using-macros.cpp
alexfh added a comment.
In https://reviews.llvm.org/D29262#709351, @krystyna wrote:
> I have plan to finish this patch next week, when I finish academic year at my
> school. If I will have any issues with submitting, Prazek offered to help me.
Sure, no stress. Good luck with your studies!
krystyna added a comment.
I have plan to finish this patch next week, when I finish academic year at my
school. If I will have any issues with submitting, Prazek offered to help me.
https://reviews.llvm.org/D29262
___
cfe-commits mailing list
alexfh added a comment.
Krystyna, do you need help committing the patch after you address the
outstanding comments?
https://reviews.llvm.org/D29262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a few comments.
Comment at: clang-tidy/modernize/UseUsingCheck.h:24
class UseUsingCheck : public ClangTidyCheck {
+
public:
nit: empty line
krystyna added a comment.
ping
https://reviews.llvm.org/D29262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krystyna updated this revision to Diff 86298.
krystyna edited the summary of this revision.
krystyna added a comment.
Style fixes.
https://reviews.llvm.org/D29262
Files:
clang-tidy/modernize/UseUsingCheck.cpp
clang-tidy/modernize/UseUsingCheck.h
