Thank you!
On Friday, February 24, 2017, Hans Wennborg wrote:
> Yes, this looks very straight-forward. Merged in r296154.
>
> On Fri, Feb 24, 2017 at 4:29 AM, Sam McCall via cfe-commits
> > wrote:
> > Thanks Anna, I'm new to the release process here.
> >
> > Hans: this is a simple fix for a null
Yes, this looks very straight-forward. Merged in r296154.
On Fri, Feb 24, 2017 at 4:29 AM, Sam McCall via cfe-commits
wrote:
> Thanks Anna, I'm new to the release process here.
>
> Hans: this is a simple fix for a null-dereference in the static analyzer.
> Does it make sense to cherrypick?
>
> On
Thanks Anna, I'm new to the release process here.
Hans: this is a simple fix for a null-dereference in the static analyzer.
Does it make sense to cherrypick?
On Sat, Feb 18, 2017 at 2:46 AM, Anna Zaks via Phabricator <
revi...@reviews.llvm.org> wrote:
> zaks.anna added a comment.
>
> Has this be
zaks.anna added a comment.
Has this been cherry-picked into the clang 4.0 release branch? If not, we
should definitely do that!
Repository:
rL LLVM
https://reviews.llvm.org/D29303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293604: In VirtualCallChecker, handle indirect calls
(authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D29303?vs=86342&id=86385#toc
Repository:
rL LLVM
https://reviews.llvm.
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D29303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
sammccall updated this revision to Diff 86342.
sammccall added a comment.
Add regression test.
https://reviews.llvm.org/D29303
Files:
lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
test/Analysis/virtualcall.cpp
Index: test/Analysis/virtualcall.cpp
=
bkramer added a comment.
Your test case is fine, it crashes with assertions enabled.
https://reviews.llvm.org/D29303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall added a comment.
I couldn't work out how to add a test for this, advice appreciated.
Closest I could get was adding something like this to
test/Analysis/virtualcall.cpp:
class F { public: F(); void foo(); };
F::F() { void (F::* ptr) = &F::foo; (this->*ptr)(); }
which crashes, but
sammccall updated this revision to Diff 86337.
sammccall added a comment.
Oops, reverted noise :(
https://reviews.llvm.org/D29303
Files:
lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
Index: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
=
sammccall created this revision.
In VirtualCallChecker, handle indirect calls.
getDirectCallee() can be nullptr, and dyn_cast(nullptr) is UB
https://reviews.llvm.org/D29303
Files:
lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
Index: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
==
11 matches
Mail list logo
