This revision was automatically updated to reflect the committed changes.
Closed by commit rL294559: [X86] Clzero flag addition and inclusion under
znver1 (authored by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D29386?vs=87437=87762#toc
Repository:
rL LLVM
GGanesh added a comment.
Thank you @craig.topper.
Just want to check if the patch can be commited to 4.0 release branch as well.
I understand that the trunk is in blocker bug-fix stage but just want to get it
confirmed.
Repository:
rL LLVM
https://reviews.llvm.org/D29386
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM, but i'll make some additional testing changes before committing it.
-Add __CLZERO__ checks to test/Preprocessor/predefined-arch-macros.c for znver1
-Add command line testing
GGanesh updated this revision to Diff 87437.
GGanesh added a comment.
Updated the builtins test for "__builtin_ia32_clzero"
Repository:
rL LLVM
https://reviews.llvm.org/D29386
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets.cpp
RKSimon added a comment.
Still missing a test in llvm\tools\clang\test\CodeGen\builtins-x86.c
Repository:
rL LLVM
https://reviews.llvm.org/D29386
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
GGanesh updated this revision to Diff 87386.
GGanesh added a comment.
Updated for review comments.
Repository:
rL LLVM
https://reviews.llvm.org/D29386
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets.cpp
lib/Headers/CMakeLists.txt
