[PATCH] D29479: Driver: Do not warn about unused -pthread when linking on darwin

MatzeB closed this revision. MatzeB added a comment. This was accepted on the mailinglist and committed in r294065 Repository: rL LLVM https://reviews.llvm.org/D29479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D29479: Driver: Do not warn about unused -pthread when linking on darwin

LGTM. > On 2017-Feb-03, at 14:16, Matthias Braun via Phabricator > wrote: > > MatzeB updated this revision to Diff 87024. > MatzeB added a comment. > > Address review comments: > > - Simplify test > - Only perform the ClaimAll() if we actually link libc, so we get

[PATCH] D29479: Driver: Do not warn about unused -pthread when linking on darwin

MatzeB updated this revision to Diff 87024. MatzeB added a comment. Address review comments: - Simplify test - Only perform the ClaimAll() if we actually link libc, so we get the warning back when combining -nostdlib/-nodefaultlibs with -pthread Repository: rL LLVM

[PATCH] D29479: Driver: Do not warn about unused -pthread when linking on darwin

MatzeB updated this revision to Diff 87023. Repository: rL LLVM https://reviews.llvm.org/D29479 Files: lib/Driver/Tools.cpp test/Driver/darwin-ld-pthread.c Index: test/Driver/darwin-ld-pthread.c === --- /dev/null +++

Re: [PATCH] D29479: Driver: Do not warn about unused -pthread when linking on darwin

Seems reasonable to me. I wonder, should this do something in the case where -nostdlib has been passed, so we're not linking against libc by default? Or should it error/warning/etc.? One comment inline below. > On 2017-Feb-02, at 16:56, Matthias Braun via Phabricator >

[PATCH] D29479: Driver: Do not warn about unused -pthread when linking on darwin

MatzeB created this revision. Herald added a subscriber: mcrosier. While there is nothing to do at link time to get pthreads support on darwin, specifying -pthread is fine and should not produce a warning about unused arguments. Repository: rL LLVM https://reviews.llvm.org/D29479 Files: