gtbercea updated this revision to Diff 93672.
gtbercea marked an inline comment as done.
gtbercea added a comment.
Fix prefix.
Repository:
rL LLVM
https://reviews.llvm.org/D29642
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
LGTM after fixing the check-prefix
Comment at: test/Driver/openmp-offload.c:595
+// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda
-save-temps
gtbercea updated this revision to Diff 93557.
gtbercea added a comment.
Change prefix name in test.
Repository:
rL LLVM
https://reviews.llvm.org/D29642
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
gtbercea updated this revision to Diff 93501.
gtbercea added a comment.
Remove redundant check.
Repository:
rL LLVM
https://reviews.llvm.org/D29642
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
Hahnfeld added inline comments.
Comment at: test/Driver/openmp-offload.c:598
+// CHK-PTXAS: ptxas{{.*}}" "-c"
+// CHK-PTXAS-NEXT: /bin/cp
This path might not be correct on all systems. Do we really need this check?
Repository:
rL LLVM
gtbercea updated this revision to Diff 93172.
gtbercea added a comment.
Herald added a subscriber: rengolin.
Update patch to reflect latest source code changes.
Repository:
rL LLVM
https://reviews.llvm.org/D29642
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload.c
