[PATCH] D29707: Fix improper microsoft-pure-definition warning on template class

2019-04-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL358849: [Sema][MSVC] Fix bogus microsoft-pure-definition warning on member function of… (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D29707: Fix improper microsoft-pure-definition warning on template class

2019-04-21 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno accepted this revision. riccibruno added a comment. This revision is now accepted and ready to land. This looks reasonable to me (although I think that the test should be in `SemaCXX/` and not in `Parser/`, but the test for the non-template case is already in `Parser/` so ok).

[PATCH] D29707: Fix improper microsoft-pure-definition warning on template class

2019-04-20 Thread Jack Adrian Zappa via Phabricator via cfe-commits
adrianh.bsc added a comment. Just wondering if this will be fixed soon. It's kinda annoying. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D29707/new/ https://reviews.llvm.org/D29707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29707: Fix improper microsoft-pure-definition warning on template class

2017-02-08 Thread Rudy Pons via Phabricator via cfe-commits
Ilod created this revision. Clang emits a warning when using pure specifier =0 in function definition at class scope, which is a MS-specific construct, when using -fms-extensions. However, to detect this, it was using FD->isCanonicalDecl() on function declaration, which was also detecting