[PATCH] D29804: Fully qualify (preprend ::) calls to math functions from libc

This revision was automatically updated to reflect the committed changes. Closed by commit rL294696: Fully qualify (preprend ::) calls to math functions from libc (authored by mehdi_amini). Changed prior to commit: https://reviews.llvm.org/D29804?vs=87933&id=87939#toc Repository: rL LLVM ht

[PATCH] D29804: Fully qualify (preprend ::) calls to math functions from libc

EricWF added a comment. This LGTM. Although IDK how far we should go to tolerate collisions with imported namespace names, especially since `libc` can't (since they can't add the ::qualifier). I've wrote tests for this change here

[PATCH] D29804: Fully qualify (preprend ::) calls to math functions from libc

mehdi_amini created this revision. This can cause a compile failure in cases like: double log(double); namespace foo { namespace log {} } using namespace foo; void bar(int i) { log((double)i); } https://reviews.llvm.org/D29804 Files: libcxx/include/math.h Index: libcxx/include/math.