aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r295114.
https://reviews.llvm.org/D29868
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:2989
+
+ Diag(Loc, diag::err_ms_attributes_not_enabled);
+ continue;
aaron.ballman wrote:
> majnemer wrote:
> > aaron.ballman wrote:
> > > compnerd wrote:
> > > > aaron.ballman
aaron.ballman marked an inline comment as done.
aaron.ballman added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:2989
+
+ Diag(Loc, diag::err_ms_attributes_not_enabled);
+ continue;
majnemer wrote:
> aaron.ballman wrote:
> > compnerd
majnemer added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:2989
+
+ Diag(Loc, diag::err_ms_attributes_not_enabled);
+ continue;
aaron.ballman wrote:
> compnerd wrote:
> > aaron.ballman wrote:
> > > compnerd wrote:
> > > > I think that
aaron.ballman marked 3 inline comments as done.
aaron.ballman added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:2989
+
+ Diag(Loc, diag::err_ms_attributes_not_enabled);
+ continue;
compnerd wrote:
> aaron.ballman wrote:
> > compnerd
aaron.ballman updated this revision to Diff 88198.
aaron.ballman added a comment.
Fixed review feedback
https://reviews.llvm.org/D29868
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParseDecl.cpp
test/Parser/declspec-recovery.c
test/Parser/declspec-supported.c
Index:
compnerd added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:2989
+
+ Diag(Loc, diag::err_ms_attributes_not_enabled);
+ continue;
aaron.ballman wrote:
> compnerd wrote:
> > I think that we want to emit the diagnostic even if there is no
aaron.ballman added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:2973
+ // recognize that scenario and recover gracefully.
+ if (!getLangOpts().MicrosoftExt && Tok.is(tok::identifier) &&
+ Tok.getIdentifierInfo()->getName().equals("__declspec")) {
aaron.ballman updated this revision to Diff 88122.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Correcting review feedback.
https://reviews.llvm.org/D29868
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParseDecl.cpp
compnerd added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:2973
+ // recognize that scenario and recover gracefully.
+ if (!getLangOpts().MicrosoftExt && Tok.is(tok::identifier) &&
+ Tok.getIdentifierInfo()->getName().equals("__declspec")) {
aaron.ballman created this revision.
In r238238, we removed __declspec as a universally-accepted keyword -- instead,
it is only enabled as a supported keyword when -fms-extensions or -fdeclspec is
passed to the driver. However, this had an unfortunate side-effect in that it
made for bad
11 matches
Mail list logo