[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea closed this revision. gtbercea added a comment. Already covered by https://reviews.llvm.org/D34888 Repository: rL LLVM https://reviews.llvm.org/D29905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea added a comment. In https://reviews.llvm.org/D29905#800416, @Hahnfeld wrote: > In https://reviews.llvm.org/D34888#799576, @gtbercea wrote: > > > Does this also include the fixes in the following revision? > > > > https://reviews.llvm.org/D29905 > > > Sorry, I wasn't aware of this

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

Hahnfeld added a comment. In https://reviews.llvm.org/D34888#799576, @gtbercea wrote: > Does this also include the fixes in the following revision? > > https://reviews.llvm.org/D29905 Sorry, I wasn't aware of this revision and thought that it had long been committed. I just verified that the

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D29905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea updated this revision to Diff 94990. gtbercea added a comment. Fix for loop range. Repository: rL LLVM https://reviews.llvm.org/D29905 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea updated this revision to Diff 94985. gtbercea added a comment. Refactor code. Repository: rL LLVM https://reviews.llvm.org/D29905 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea updated this revision to Diff 94983. gtbercea added a comment. Clean-up. Repository: rL LLVM https://reviews.llvm.org/D29905 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:343 +for (unsigned I = Stack.size() - 1; I > 0; --I) + if (checkMappableExprComponentListsForDeclAtLevel(VD, I - 2, Check)) +return true; Are you sure this is correct? If I is 1,

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea updated this revision to Diff 94972. gtbercea added a comment. Pass correct levels. Refactor code. Repository: rL LLVM https://reviews.llvm.org/D29905 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea updated this revision to Diff 94867. gtbercea added a comment. Refactor code. Repository: rL LLVM https://reviews.llvm.org/D29905 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:358-360 + /// Do the check specified in \a Check to all component lists at a given level + /// and return true if any issue is found. + bool checkMappableExprComponentListsForDeclAtLevel(

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:358-360 + /// Do the check specified in \a Check to all component lists at a given level + /// and return true if any issue is found. + bool

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:358-360 + /// Do the check specified in \a Check to all component lists at a given level + /// and return true if any issue is found. + bool checkMappableExprComponentListsForDeclAtLevel(

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea updated this revision to Diff 93859. gtbercea added a comment. Herald added a subscriber: rengolin. Update test. Repository: rL LLVM https://reviews.llvm.org/D29905 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea created this revision. When a scalar argument is explicitly mapped, the device kernel needs to be passed that argument by reference. This is a partial fix to this bug . The full fix requires data sharing support which will land in future