This revision was automatically updated to reflect the committed changes.
Closed by commit rL297465: Print nested name specifiers for typedefs and type
aliases (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D29944?vs=88376&id=91342#toc
Repository:
rL LLVM
https://
arphaman added a comment.
In https://reviews.llvm.org/D29944#697587, @redm123 wrote:
> I guess so. I don't think I'm allowed to commit. So I would appreciate it.
Sure, I will commit it right now.
> Which release version would that be in? 4.1 I guess?
It will be in the next major release: 5.0
redm123 added a comment.
I guess so. I don't think I'm allowed to commit. So I would appreciate it.
Which release version would that be in? 4.1 I guess?
Thanks for your help!
https://reviews.llvm.org/D29944
___
cfe-commits mailing list
cfe-commits
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the fix. Do you need someone to commit it for you?
https://reviews.llvm.org/D29944
___
cfe-commits mailing list
cfe-commits@
arphaman added inline comments.
Comment at: test/Misc/diag-template-diffing.cpp:27
// CHECK-ELIDE-NOTREE: no matching function for call to 'f'
-// CHECK-ELIDE-NOTREE: candidate function not viable: no known conversion from
'vector' to 'vector' for 1st argument
+// CHECK-ELIDE-N
redm123 added a comment.
Any idea how to continue with that? Should I add another reviewer? Whom?
https://reviews.llvm.org/D29944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
redm123 added inline comments.
Comment at: test/Misc/diag-template-diffing.cpp:27
// CHECK-ELIDE-NOTREE: no matching function for call to 'f'
-// CHECK-ELIDE-NOTREE: candidate function not viable: no known conversion from
'vector' to 'vector' for 1st argument
+// CHECK-ELIDE-NO
redm123 added inline comments.
Comment at: test/Misc/diag-template-diffing.cpp:27
// CHECK-ELIDE-NOTREE: no matching function for call to 'f'
-// CHECK-ELIDE-NOTREE: candidate function not viable: no known conversion from
'vector' to 'vector' for 1st argument
+// CHECK-ELIDE-NO
arphaman added inline comments.
Comment at: test/Misc/diag-template-diffing.cpp:27
// CHECK-ELIDE-NOTREE: no matching function for call to 'f'
-// CHECK-ELIDE-NOTREE: candidate function not viable: no known conversion from
'vector' to 'vector' for 1st argument
+// CHECK-ELIDE-N
redm123 added a comment.
In https://reviews.llvm.org/D29944#678033, @arphaman wrote:
> Do these diagnostics have the full qualifiers for errors that occur with
> record types instead of typedefs?
Not sure what you mean by that, but as far as I can see all the changed errors
refer to typedefs/
arphaman added a comment.
I'm quite surprised by the fact that we have to change so many diagnostics in
tests. Do these diagnostics have the full qualifiers for errors that occur with
record types instead of typedefs?
https://reviews.llvm.org/D29944
_
As an explanation for this patch my original mail to cfe-dev:
I'm using libclang to parse header files and generate code from them. I
found that clang_getTypeSpelling() usually includes the namespace(s) a
type was declared in. However with the exception being typedefs (and
same for "using A =
redm123 created this revision.
Printing typedefs or type aliases using clang_getTypeSpelling() is missing the
namespace they are defined in. This is in contrast to other types that always
yield the full typename including namespaces.
https://reviews.llvm.org/D29944
Files:
lib/AST/TypePrinte
13 matches
Mail list logo
