erikjv closed this revision.
erikjv added a comment.
Landed as r298903.
https://reviews.llvm.org/D30248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Let's fix those crashes one at a time. This patch looks good, only minor
comments below.
Comment at: lib/Sema/SemaOverload.cpp:6311
+ if (isa(FD) &&
arphaman added a comment.
It seems that unresolved member expressions have other lookup issues. For
example, this will crash when code-completing as well:
struct Foo {
void foo() const;
static void foo(bool);
};
struct Bar: Foo {
void foo(bool param) {
this->Foo::foo(/*CC
erikjv created this revision.
If there is an unresolved member access AST node, and the base is
implicit, do not access/use it for generating candidate overloads for
code completion results (because the base is a nullptr).
Fixes PR31093.
https://reviews.llvm.org/D30248
Files:
