pirama added inline comments.
Comment at: lib/Driver/ToolChain.cpp:652
+// libc++ may be installed per arch.
+addArchSpecificRPath(*this, Args, CmdArgs);
break;
Hahnfeld wrote:
> pirama wrote:
> > `addArchSpecificRPath` is a static function in Tools.
mgorny added a comment.
I'm sorry, I've completely forgot that the path contains version number. In
this case, it indeed probably doesn't make much sense to add rpath for that.
https://reviews.llvm.org/D30733
___
cfe-commits mailing list
cfe-commit
joerg added a comment.
Installing libc++ along clang makes a lot of sense for non-system compilers. It
doesn't imply any version locking like in GCC, i.e. you are still free to
install whatever version of libunwind and libc++ you want. I'm somewhat
conflicted about this patch. I think it is an
jroelofs added a comment.
I'll also add that we had a BOF at EuroLLVM 2014, where this got support from
the community and people generally thought it was a good plan... Just needed
someone to follow through with it.
We (wearing my CodeSourcery hat) said we would do so, but have been making slow
jroelofs added a comment.
In https://reviews.llvm.org/D30733#697313, @Hahnfeld wrote:
> In https://reviews.llvm.org/D30733#697108, @jroelofs wrote:
>
> > As I said on https://reviews.llvm.org/D30214, it is inappropriate to be
> > installing libc++ in the resource directory... please **do not** d
Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
In https://reviews.llvm.org/D30733#697108, @jroelofs wrote:
> As I said on https://reviews.llvm.org/D30214, it is inappropriate to be
> installing libc++ in the resource directory... please **do not** do that.
Can you give re
jroelofs requested changes to this revision.
jroelofs added a comment.
This revision now requires changes to proceed.
As I said on https://reviews.llvm.org/D30214, it is inappropriate to be
installing libc++ in the resource directory... please **do not** do that.
https://reviews.llvm.org/D30733
pirama added inline comments.
Comment at: lib/Driver/ToolChain.cpp:652
+// libc++ may be installed per arch.
+addArchSpecificRPath(*this, Args, CmdArgs);
break;
`addArchSpecificRPath` is a static function in Tools.cpp and isn't visible here.
https:
Hahnfeld created this revision.
Herald added a reviewer: EricWF.
libc++ may be installed there as a runtime library.
https://reviews.llvm.org/D30733
Files:
lib/Driver/ToolChain.cpp
Index: lib/Driver/ToolChain.cpp
===
--- lib/Dr