This revision was automatically updated to reflect the committed changes.
Closed by commit rL298126: Implement DR 373 "Lookup on namespace qualified name
in using-directive" (authored by mgehre).
Changed prior to commit:
https://reviews.llvm.org/D30848?vs=91956&id=92209#toc
Repository:
rL LL
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM
https://reviews.llvm.org/D30848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
mgehre updated this revision to Diff 91956.
mgehre added a comment.
Improve diagnostics and add tests for them.
https://reviews.llvm.org/D30848
Files:
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseExprCXX.cpp
lib/Sema/SemaCXXScopeSpec
rsmith added a comment.
Functionally, this looks good. How do the diagnostics look in the case where
lookup only finds a non-namespace name? Eg,
struct A { struct B {}; };
namespace X = A::B;
https://reviews.llvm.org/D30848
___
cfe-commits mai
mgehre updated this revision to Diff 91424.
mgehre added a comment.
Added clang version to test and regenerated cxx_dr_status.html
https://reviews.llvm.org/D30848
Files:
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseExprCXX.cpp
lib/Se
rsmith added inline comments.
Comment at: test/CXX/drs/dr3xx.cpp:911
-namespace dr373 { // dr373: no
- // FIXME: This is valid.
- namespace X { int dr373; } // expected-note 2{{here}}
+namespace dr373 { // dr373: yes
+ namespace X { int dr373; }
This should
mgehre updated this revision to Diff 91418.
mgehre added a comment.
clang-format
https://reviews.llvm.org/D30848
Files:
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseExprCXX.cpp
lib/Sema/SemaCXXScopeSpec.cpp
test/CXX/drs/dr3xx.cpp
mgehre created this revision.
3.4.6 [basic.lookup.udir] paragraph 1:
In a using-directive or namespace-alias-definition, during the lookup for a
namespace-name or for a name in a nested-name-specifier, only namespace names
are considered.
https://reviews.llvm.org/D30848
Files:
include/clang