[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-12-07 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi added a comment. Ping https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-11-23 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi added a comment. Ping https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-10-31 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi added a comment. Ping https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-10-09 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi added a comment. Any feedback is appreciated! https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-09-27 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi added a comment. Ping :) https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-09-07 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi added a comment. Hello Richard, what do you think about the printing context changes? Are they what you expected? https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-08-28 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi added a comment. Ping :) https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-08-21 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi added a comment. Ping :) https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-07-18 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi added a comment. Ping :) https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-07-09 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi added a comment. Ping :) https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-06-29 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi updated this revision to Diff 104655. schroedersi added a comment. I forgot to add the previous changes in Diff 104649 (it only contains the incremental diff of the printing context changes). This diff contains all changes

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-06-29 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi updated this revision to Diff 104649. schroedersi added a comment. In https://reviews.llvm.org/D30946#792798, @rsmith wrote: > I'd be interested to see how much complexity that adds, if you're prepared to > give it a try. Thanks for your feedback :). I added a printing context and

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-06-27 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In https://reviews.llvm.org/D30946#754103, @schroedersi wrote: > As an alternative to the current solution, the above-mentioned member > functions could each be extended by a "PrintingContext" argument, which then > contains the variable states. I'd be interested to

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-06-14 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi added a comment. Would it help the acceptance of the patch if I add a fourth option `LegacySuppressScope` (or similar) that emulates the current/pre-patch `SuppressScope==true`? This way the patched type printing would be a real superset of the current/non-patched type printing

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-06-12 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi added a comment. Ping :) https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-06-01 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi added a comment. Ping :) https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-05-13 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi added a comment. In https://reviews.llvm.org/D30946#740567, @bkramer wrote: > Also the mutable state in PrintingPolicy is really really ugly, is there no > better way for this? :( Thanks for your comment :-) I assume with mutable state you mean

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-05-13 Thread Simon Schroeder via Phabricator via cfe-commits
schroedersi updated this revision to Diff 98887. schroedersi added a comment. - Ran clang-format (current trunk version) on the changes (except on some test files) - Adapted patch to current trunk version https://reviews.llvm.org/D30946 Files: include/clang/AST/PrettyPrinter.h

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-04-28 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer added a comment. Can you please run clang-format on this change? There are pieces that don't follow the style. Also the mutable state in PrintingPolicy is really really ugly, is there no better way for this? :( https://reviews.llvm.org/D30946

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

2017-03-14 Thread Simon Schröder via Phabricator via cfe-commits
schroedersi created this revision. Herald added subscribers: mgorny, klimek. PrintingPolicy::SuppressScope was replaced by PrintingPolicy::Scope. Possible values for PrintingPolicy::Scope are: - FullScope: Print all nested name specifiers (including the global scope specifier). This is