dexonsmith closed this revision.
dexonsmith marked an inline comment as done.
dexonsmith added a comment.
And committed in:
r297770 c0c27f3 Modules: Optimize bitcode encoding of diagnostic state
r300021 5e5be8e Serialization: Skip check in WritePragmaDiagnosticMappings, NFC
r300024 91f051f
dexonsmith added a comment.
Thanks for the review! Somehow I missed it until now (I think I must have an
"ignore rsmith" filter set up), but I should find a chance to rebase and commit
tomorrow or Monday.
https://reviews.llvm.org/D30954
___
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
> - The patch-as-is checks whether pragmas should be demoted to warnings for
> all AST files, not just implicit modules. I can add a bit of logic to
> `ReadPragmaDiagnosticMappings`
dexonsmith added a comment.
Ping!
https://reviews.llvm.org/D30954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dexonsmith created this revision.
This is a follow-up to r293123 that makes it work with implicit modules.
Some background:
An implicit module build (using Clang's internal build system) uses the same
PCM file location for different `-Werror` levels.
E.g., if a TU has
