This revision was automatically updated to reflect the committed changes.
Closed by commit rL298477: Suppress warning on unreachable
[[clang::fallthrough]] within a template… (authored by rsmith).
Changed prior to commit:
https://reviews.llvm.org/D31069?vs=92104&id=92588#toc
Repository:
rL L
ahmedasadi added a comment.
Thanks for reviewing. Yes, I need someone to commit for me.
https://reviews.llvm.org/D31069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, do you need someone to commit for you?
https://reviews.llvm.org/D31069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
ahmedasadi updated this revision to Diff 92104.
ahmedasadi added a comment.
Added a test case.
https://reviews.llvm.org/D31069
Files:
lib/Sema/AnalysisBasedWarnings.cpp
test/SemaCXX/P30636.cpp
Index: test/SemaCXX/P30636.cpp
=
rsmith added a comment.
This needs a test case, but the change itself looks fine to me.
Repository:
rL LLVM
https://reviews.llvm.org/D31069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe