hokein added a comment.
> are the tools like clang-rename, change-namespace and clang-reorder-fields
> supposed to use AtomicChange (via the methods insert, replace etc) ?
Yeah. We are using AtomicChange in clang-rename refinement
(https://reviews.llvm.org/D31176).
Repository:
rL LLVM
http
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299073: Add `replace` interface with range in AtomicChange.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D31492?vs=93472&id=93473#toc
Repository:
rL LLVM
https://reviews.l
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Looks good and thanks for the cleanup.
https://reviews.llvm.org/D31492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
hokein updated this revision to Diff 93472.
hokein added a comment.
Add unittest.
https://reviews.llvm.org/D31492
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
lib/Tooling/Refactoring/AtomicChange.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/Tooling/RefactoringTes
ioeric added a comment.
Could you add a simple test?
https://reviews.llvm.org/D31492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 93467.
hokein added a comment.
Rebase to master.
https://reviews.llvm.org/D31492
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
lib/Tooling/Refactoring/AtomicChange.cpp
Index: lib/Tooling/Refactoring/AtomicChange.cpp
==
ioeric added a comment.
In https://reviews.llvm.org/D31492#713908, @alexshap wrote:
> to avoid misunderstanding - are the tools like clang-rename, change-namespace
> and clang-reorder-fields supposed to use AtomicChange (via the methods
> insert, replace etc) ?
> (i am asking just to make sure
alexshap added a comment.
to avoid misunderstanding - are the tools like clang-rename, change-namespace
and clang-reorder-fields supposed to use AtomicChange (via the methods insert,
replace etc) ?
(i am asking just to make sure i understand correctly the intentions behind
AtomicChange interfac
