On 6/4/20 6:58 AM, Sean Silva wrote:
Can we revert this?
In our downstream project we were bitten by this:
https://github.com/google/mlir-npcomp/commit/cd7258dbd48bd9254c6741cab2d3f4e36cbd3c84
It seems that now by default anybody that depends on LLVM with CMake
will globally get a `-w`
Can we revert this?
In our downstream project we were bitten by this:
https://github.com/google/mlir-npcomp/commit/cd7258dbd48bd9254c6741cab2d3f4e36cbd3c84
It seems that now by default anybody that depends on LLVM with CMake will
globally get a `-w` passed to their compiler. That doesn't seem
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r300100.
https://reviews.llvm.org/D31702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D31702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
v.g.vassilev updated this revision to Diff 94180.
v.g.vassilev marked an inline comment as done.
v.g.vassilev added a comment.
Ah good point. Thanks!
https://reviews.llvm.org/D31702
Files:
cmake/modules/HandleLLVMOptions.cmake
Index: cmake/modules/HandleLLVMOptions.cmake
yaron.keren added inline comments.
Comment at: cmake/modules/HandleLLVMOptions.cmake:562
add_flag_if_supported("-Wstring-conversion" STRING_CONVERSION_FLAG)
+else()
+ append("-w" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
note this is an else to
if
v.g.vassilev created this revision.
Herald added a subscriber: mgorny.
This is very useful for projects which embed LLVM in their codebases.
Repository:
rL LLVM
https://reviews.llvm.org/D31702
Files:
cmake/modules/HandleLLVMOptions.cmake
Index: cmake/modules/HandleLLVMOptions.cmake
