This revision was automatically updated to reflect the committed changes.
Closed by commit rL299691: [AMDGPU] Temporarily change constant address space
from 4 to 2 for the new… (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D31771?vs=94386=94418#toc
Repository:
rL
t-tye added a comment.
LGTM
Comment at: lib/Basic/Targets.cpp:2083
Local = 3;
-Constant = 4;
+Constant = 2;
Private = 5;
t-tye wrote:
> Since Constant is now the same regardless of the GIZ setting, should it be
>
t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.
Other than one comment:
LGTM
Comment at: lib/Basic/Targets.cpp:2083
Local = 3;
-Constant = 4;
+Constant = 2;
Private = 5;
yaxunl created this revision.
Herald added subscribers: tpr, dstuttard, nhaehnle, wdng, kzhuravl.
Change constant address space from 4 to 2 for the new address space mapping in
Clang.
https://reviews.llvm.org/D31771
Files:
lib/Basic/Targets.cpp
