xbolva00 added a comment.
Are you gonna commit this patch?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D31839/new/
https://reviews.llvm.org/D31839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nlewycky added a comment.
Ping!
https://reviews.llvm.org/D31839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nlewycky added a comment.
Ping!
https://reviews.llvm.org/D31839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nlewycky updated this revision to Diff 97253.
nlewycky added a comment.
Use an RAII object to always evaluate the arguments, except if
HandleFunctionCall does it.
https://reviews.llvm.org/D31839
Files:
lib/AST/ExprConstant.cpp
test/Sema/integer-overflow.c
Index:
nlewycky added a comment.
In https://reviews.llvm.org/D31839#724551, @ahatanak wrote:
> OK, thanks for looking into it. Warnings for ObjCMessageExpr can probably be
> implemented in a separate patch.
>
> It looks like clang still doesn't issue overflow warnings when the called
> functions have
ahatanak added a comment.
OK, thanks for looking into it. Warnings for ObjCMessageExpr can probably be
implemented in a separate patch.
It looks like clang still doesn't issue overflow warnings when the called
functions have a void return. Should we try to fix it in this patch too?
void
nlewycky added a comment.
In https://reviews.llvm.org/D31839#722763, @ahatanak wrote:
> Is it possible to fix ObjCMessageExpr too while you are in here?
I looked into this, but it turns out to be different enough to belong in a
separate patch. An ObjCMessageExpr has void type which means that
ahatanak added a comment.
Is it possible to fix ObjCMessageExpr too while you are in here?
I think clang should issue a warning when compiling the following code:
@protocol NSObject
@end
@interface NSObject
@end
@interface C1 : NSObject
- (void)foo:(int)i;
@end
nlewycky created this revision.
When checkingForOverflow(), look through call arguments (and the callee itself
if calculated).
Make the statement visitor go through ObjCBoxedExpr by default because it has a
single subexpr node. Don't do that when looking for a pointer object, stop
because the
