NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yep, looks good now, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D31840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexshap updated this revision to Diff 94713.
alexshap added a comment.
1. update the patch following NoQ@ suggestion
2. rerun the tests: make check-all - they are green
Repository:
rL LLVM
https://reviews.llvm.org/D31840
Files:
lib/StaticAnalyzer/Core/CallEvent.cpp
NoQ added a comment.
This defensive check looks reasonable regardless of how well we model unions
(we don't). Thanks for the patch!
Comment at: lib/StaticAnalyzer/Core/CallEvent.cpp:706
+ }
Values.push_back(IvarLVal);
return;
I believe
alexshap created this revision.
alexshap created this object with visibility "All Users".
Preliminary context about unions:
at the moment for unions the static analyzer creates default bindings (as a
compoundVal).
If a union has only one field x which is initialized to zero this is handled as
