This revision was automatically updated to reflect the committed changes.
Closed by commit rL299935: [clangd] Implement item kind for completion results
(authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D31853?vs=94720=94811#toc
Repository:
rL LLVM
Thanks for the review!
Yes, unfortunately I still need someone to commit it.
On Apr 11, 2017 15:21, "Krasimir Georgiev via Phabricator" <
revi...@reviews.llvm.org> wrote:
krasimir added a comment.
Do you still need someone to commit this?
https://reviews.llvm.org/D31853
krasimir added a comment.
Do you still need someone to commit this?
https://reviews.llvm.org/D31853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good! Thank you!
https://reviews.llvm.org/D31853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
stanionascu added a comment.
In https://reviews.llvm.org/D31853#722219, @krasimir wrote:
> Looks good! However it would be easier for reviewers if you could please use
> arc: http://llvm.org/docs/Phabricator.html#id2
> This makes it easy since I only have to do `arc patch D31853` in order to
stanionascu updated this revision to Diff 94720.
stanionascu added a comment.
One more try updating the revision on fresh git+svn clone.
https://reviews.llvm.org/D31853
Files:
clangd/ASTManager.cpp
clangd/Protocol.cpp
test/clangd/completion.test
Index: test/clangd/completion.test
stanionascu updated this revision to Diff 94716.
stanionascu added a comment.
recreated from svn checkout
https://reviews.llvm.org/D31853
Files:
clangd/ASTManager.cpp
clangd/Protocol.cpp
test/clangd/completion.test
Index: test/clangd/completion.test
krasimir requested changes to this revision.
krasimir added a comment.
This revision now requires changes to proceed.
Looks good! However it would be easier for reviewers if you could please use
arc: http://llvm.org/docs/Phabricator.html#id2
This makes it easy since I only have to do `arc patch
stanionascu created this revision.
stanionascu added a project: clang-tools-extra.
The patch implements the conversion method from CXCursorKind to
clangd::CompletionItemKind.
https://reviews.llvm.org/D31853
Files:
clangd/ASTManager.cpp
clangd/Protocol.cpp
test/clangd/completion.test
