alexfh added inline comments.
Comment at: docs/clang-tidy/checks/misc-unused-parameters.rst:15
+
+ void a(int /*i*/) {}
+
sylvestre.ledru wrote:
> alexfh wrote:
> > nit: two spaces before the comment.
> I believe it is the case ?
> I stole this from the unit
sylvestre.ledru added inline comments.
Comment at: docs/clang-tidy/checks/misc-unused-parameters.rst:15
+
+ void a(int /*i*/) {}
+
alexfh wrote:
> nit: two spaces before the comment.
I believe it is the case ?
I stole this from the unit test
alexfh added a comment.
Another couple of post-commit comments.
Comment at: docs/clang-tidy/checks/misc-unused-parameters.rst:15
+
+ void a(int /*i*/) {}
+
nit: two spaces before the comment.
Comment at:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thanks!
LG with a couple of nits.
Comment at: docs/clang-tidy/checks/misc-inefficient-algorithm.rst:25
+ std::set s;
+ auto c = count(s.begin(), s.end(), 43);
+
sylvestre.ledru created this revision.
sylvestre.ledru added a project: clang-tools-extra.
https://reviews.llvm.org/D31860
Files:
docs/clang-tidy/checks/llvm-namespace-comment.rst
docs/clang-tidy/checks/llvm-twine-local.rst
docs/clang-tidy/checks/misc-inefficient-algorithm.rst
