This revision was automatically updated to reflect the committed changes.
Closed by commit rL314056: Promote storage-only __fp16 vector operands to float
vectors. (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D32520?vs=116275=116533#toc
Repository:
rL LLVM
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks Akira.
https://reviews.llvm.org/D32520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ahatanak added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1042
+}
+
+assert(SrcElementTy->isFloatingPointTy() &&
bruno wrote:
> What happens if the SrcElementTy is float and DstElementTy isn't? Seems like
> it will hit the assertion
ahatanak updated this revision to Diff 116275.
ahatanak marked 8 inline comments as done.
ahatanak added a comment.
Address review comments.
https://reviews.llvm.org/D32520
Files:
lib/CodeGen/CGExprScalar.cpp
lib/Sema/SemaExpr.cpp
test/CodeGen/fp16vec-ops.c
test/Sema/fp16vec-sema.c
ahatanak updated this revision to Diff 115966.
ahatanak added a comment.
Upload the rebased patch again.
https://reviews.llvm.org/D32520
Files:
include/clang/Sema/Sema.h
lib/CodeGen/CGExprScalar.cpp
lib/Sema/SemaExpr.cpp
test/CodeGen/fp16vec-ops.c
test/Sema/fp16vec-sema.c
Index:
ahatanak reopened this revision.
ahatanak added a comment.
Reopening this review. I accidentally closed this review when I committed
r313717 (the patch that adds support for 'noescape').
Repository:
rL LLVM
https://reviews.llvm.org/D32520
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313720: Add support for attribute 'noescape'. (authored by
ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D32520?vs=115304=115964#toc
Repository:
rL LLVM
bruno added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1042
+}
+
+assert(SrcElementTy->isFloatingPointTy() &&
What happens if the SrcElementTy is float and DstElementTy isn't? Seems like it
will hit the assertion below.
ahatanak updated this revision to Diff 115304.
ahatanak added a comment.
Rebase.
https://reviews.llvm.org/D32520
Files:
include/clang/Sema/Sema.h
lib/CodeGen/CGExprScalar.cpp
lib/Sema/SemaExpr.cpp
test/CodeGen/fp16vec-ops.c
test/Sema/fp16vec-sema.c
Index: test/Sema/fp16vec-sema.c
ahatanak added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:997
- // Allow bitcast from vector to integer/fp of the same size.
- if (isa(SrcTy) ||
- isa(DstTy))
-return Builder.CreateBitCast(Src, DstTy, "conv");
+ if (isa(SrcTy) || isa(DstTy)) {
+
ahatanak updated this revision to Diff 102642.
ahatanak marked 3 inline comments as done.
ahatanak added a comment.
Herald added a subscriber: kristof.beyls.
Address review comments.
https://reviews.llvm.org/D32520
Files:
include/clang/Sema/Sema.h
lib/CodeGen/CGExprScalar.cpp
bruno added a comment.
Hi Akira,
This is nice, thanks for doing it!
Comment at: include/clang/Sema/Sema.h:9270
+ QualType RHSType,
+ bool CompAssign = false);
Can
ahatanak updated this revision to Diff 100354.
ahatanak added a comment.
Rebase.
https://reviews.llvm.org/D32520
Files:
include/clang/Sema/Sema.h
lib/CodeGen/CGExprScalar.cpp
lib/Sema/SemaExpr.cpp
test/CodeGen/fp16vec-ops.c
test/Sema/fp16vec-sema.c
Index: test/Sema/fp16vec-sema.c
ahatanak added a comment.
ping
https://reviews.llvm.org/D32520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak created this revision.
Herald added subscribers: rengolin, aemerson.
Currently, clang miscompiles operations on __fp16 vectors.
For example, when the following code is compiled:
typedef __fp16 half4 __attribute__ ((vector_size (8)));
half4 hv0, hv1, hv2;
void test() {
hv0
15 matches
Mail list logo
