jroelofs added a comment.
In https://reviews.llvm.org/D33259#772184, @mgorny wrote:
> This causes a test failure with non-standard CLANG_RESOURCE_DIR:
https://reviews.llvm.org/D33877
(thanks for the patch)
https://reviews.llvm.org/D33259
___
cfe
mgorny added a comment.
This causes a test failure with non-standard CLANG_RESOURCE_DIR:
Command Output (stderr):
--
/var/tmp/portage/sys-devel/clang-/work/x/y/clang-/test/Driver/baremetal.cpp:8:22:
error: expected string not found in input
// CHECK-V6M-C-SAME: "-resource-dir"
jroelofs closed this revision.
jroelofs added a comment.
r303873
https://reviews.llvm.org/D33259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs updated this revision to Diff 100177.
jroelofs marked an inline comment as done.
jroelofs added a comment.
Fix a cmake warning:
Platform/baremetal to use this system, please send your config file to
cm...@www.cmake.org so it can be added to cmake
Your CMakeCache.txt file was copied
jroelofs marked 2 inline comments as done.
jroelofs added inline comments.
Comment at: lib/Driver/ToolChains/BareMetal.cpp:110
+ SmallString<128> Dir(SysRoot);
+ llvm::sys::path::append(Dir, "include", "c++", "v1");
+ return Dir.str();
compnerd wrote:
> Is thi
jroelofs updated this revision to Diff 100131.
jroelofs added a comment.
implement feedback
https://reviews.llvm.org/D33259
Files:
cmake/caches/BaremetalARM.cmake
lib/Driver/CMakeLists.txt
lib/Driver/Driver.cpp
lib/Driver/ToolChains/BareMetal.cpp
lib/Driver/ToolChains/BareMetal.h
li
compnerd added a comment.
Looks generally pretty good. This is going to be a pretty cool addition!
Comment at: lib/Driver/ToolChains/BareMetal.cpp:68
+ SmallString<128> Dir(getDriver().ResourceDir);
+ llvm::sys::path::append(Dir, "lib", "baremetal");
+ return Dir.str();
---
jroelofs updated this revision to Diff 100018.
jroelofs added a comment.
fixed the v7m/v7em part of the build
https://reviews.llvm.org/D33259
Files:
cmake/caches/BaremetalARM.cmake
lib/Driver/CMakeLists.txt
lib/Driver/Driver.cpp
lib/Driver/ToolChains/BareMetal.cpp
lib/Driver/ToolChain
jroelofs planned changes to this revision.
jroelofs added inline comments.
Comment at: cmake/caches/BaremetalARM.cmake:10
+
+set(BUILTINS_armv7m-none-eabi_CMAKE_SYSROOT ${BAREMETAL_ARMV7M_SYSROOT} CACHE
STRING "armv7m-none-eabi Sysroot")
+set(BUILTINS_armv7m-none-eabi_CMAKE_SYST
jroelofs updated this revision to Diff 99950.
https://reviews.llvm.org/D33259
Files:
cmake/caches/BaremetalARM.cmake
lib/Driver/CMakeLists.txt
lib/Driver/Driver.cpp
lib/Driver/ToolChains/BareMetal.cpp
lib/Driver/ToolChains/BareMetal.h
test/Driver/Inputs/baremetal_arm/include/c++/v1/.k
jroelofs added inline comments.
Comment at: lib/Driver/ToolChains/BareMetal.cpp:68
+ SmallString<128> Dir(getDriver().ResourceDir);
+ llvm::sys::path::append(Dir, "lib", "baremetal");
+ return Dir.str();
compnerd wrote:
> jroelofs wrote:
> > compnerd wrote:
>
compnerd added inline comments.
Comment at: lib/Driver/ToolChains/BareMetal.cpp:68
+ SmallString<128> Dir(getDriver().ResourceDir);
+ llvm::sys::path::append(Dir, "lib", "baremetal");
+ return Dir.str();
jroelofs wrote:
> compnerd wrote:
> > jroelofs wrote:
>
ruiu added inline comments.
Comment at: lib/Driver/ToolChains/BareMetal.h:42
+
+ const char *getDefaultLinker() const override { return "ld.lld"; }
+
jroelofs wrote:
> compnerd wrote:
> > jroelofs wrote:
> > > compnerd wrote:
> > > > I think that this really sho
jroelofs added inline comments.
Comment at: cmake/caches/BaremetalARM.cmake:1
+set(LLVM_TARGETS_TO_BUILD ARM CACHE STRING "")
+
compnerd wrote:
> jroelofs wrote:
> > compnerd wrote:
> > > Please rename this file to `BareMetalARMv6.cmake`. (I'm interested in
> >
compnerd added inline comments.
Comment at: cmake/caches/BaremetalARM.cmake:1
+set(LLVM_TARGETS_TO_BUILD ARM CACHE STRING "")
+
jroelofs wrote:
> compnerd wrote:
> > Please rename this file to `BareMetalARMv6.cmake`. (I'm interested in the
> > suffix primarily)
jroelofs marked 2 inline comments as done.
jroelofs added inline comments.
Comment at: lib/Driver/ToolChains/BareMetal.cpp:107-108
+ArgStringList &CmdArgs) const {
+ CmdArgs.push_back("-lc++");
+ CmdArgs.push_back("-lc++abi");
+ CmdArgs.push
jroelofs updated this revision to Diff 99350.
https://reviews.llvm.org/D33259
Files:
cmake/caches/BaremetalARM.cmake
lib/Driver/CMakeLists.txt
lib/Driver/Driver.cpp
lib/Driver/ToolChains/BareMetal.cpp
lib/Driver/ToolChains/BareMetal.h
test/Driver/Inputs/baremetal_arm/include/c++/v1/.k
jroelofs added inline comments.
Comment at: lib/Driver/ToolChains/BareMetal.h:42
+
+ const char *getDefaultLinker() const override { return "ld.lld"; }
+
compnerd wrote:
> I think that this really should be `ld` still, as that is the canonical name
> for the li
jroelofs planned changes to this revision.
jroelofs added inline comments.
Comment at: cmake/caches/BaremetalARM.cmake:1
+set(LLVM_TARGETS_TO_BUILD ARM CACHE STRING "")
+
compnerd wrote:
> Please rename this file to `BareMetalARMv6.cmake`. (I'm interested in the
compnerd requested changes to this revision.
compnerd added inline comments.
This revision now requires changes to proceed.
Comment at: cmake/caches/BaremetalARM.cmake:1
+set(LLVM_TARGETS_TO_BUILD ARM CACHE STRING "")
+
Please rename this file to `BareMetalARMv6.
jroelofs added a comment.
> I would expect this to changes wildly depending on the specific environment.
My assertion is that our default "specific environment" ought to cater to using
llvm's own tools... at least until someone comes along and says they actually
want `-fuse-ld=gcc`, or whatever
joerg added a comment.
While I fully agree that the current fallback-to-GCC behavior is far from
helpful, I'm not sure how much sense providing linker support for bare-metal
makes. I would expect this to changes wildly depending on the specific
environment.
https://reviews.llvm.org/D33259
jroelofs updated this revision to Diff 99210.
jroelofs added a comment.
pass through linker flags, and remove my own paths from the test.
https://reviews.llvm.org/D33259
Files:
cmake/caches/BaremetalARM.cmake
lib/Driver/CMakeLists.txt
lib/Driver/Driver.cpp
lib/Driver/ToolChains/BareMeta
jroelofs created this revision.
Herald added subscribers: javed.absar, mgorny, rengolin, aemerson.
https://reviews.llvm.org/D33259
Files:
cmake/caches/BaremetalARM.cmake
lib/Driver/CMakeLists.txt
lib/Driver/Driver.cpp
lib/Driver/ToolChains/BareMetal.cpp
lib/Driver/ToolChains/BareMetal.h
24 matches
Mail list logo
