[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-29 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. Thanks for fixing the failures. Sorry for not being around to look into that myself. Comment at: clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp:123 + TmpDirs.push_back(TmpDir1.str()); + if (TmpDir2 != TmpDir2) +TmpDirs.push_back(T

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-27 Thread NAKAMURA Takumi via Phabricator via cfe-commits
chapuni added inline comments. Comment at: clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp:123 + TmpDirs.push_back(TmpDir1.str()); + if (TmpDir2 != TmpDir2) +TmpDirs.push_back(TmpDir2.str()); Did you mean, "TmpDir1 != TmpDir2" ? Fixed in r304067.

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL303977: [clangd] Allow to use vfs::FileSystem for file accesses. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D33416?vs=100262&id=100389#toc Repository: rL LLVM https:/

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-25 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 100262. ilya-biryukov added a comment. - Fixed file comment of ClangdTests.cpp https://reviews.llvm.org/D33416 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-24 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good. Make sure to watch the windows buildbots after submitting. https://reviews.llvm.org/D33416 ___ cfe-commits mailing list cfe-commits

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-24 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 100065. ilya-biryukov added a comment. Minor refactoring to address @krasimir's comments https://reviews.llvm.org/D33416 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-24 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: unittests/clangd/ClangdTests.cpp:298 + const auto SourceContents = + R"cpp( +#include "foo.h" Move this to the previous line. Comment at: unittests/clangd/ClangdTests.cpp:336 + const auto Sourc

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-23 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 99902. ilya-biryukov added a comment. Changed tests to use Windows-style paths for virtual directory when running on Windows. https://reviews.llvm.org/D33416 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clan

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-23 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: unittests/clangd/ClangdTests.cpp:118 + llvm::SmallString<128> TmpDir2; + llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/true, TmpDir2); + bkramer wrote: > We should delete those when we're done, otherw

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-23 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer added inline comments. Comment at: unittests/clangd/ClangdTests.cpp:118 + llvm::SmallString<128> TmpDir2; + llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/true, TmpDir2); + We should delete those when we're done, otherwise the unit test will

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-22 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. Herald added a subscriber: mgorny. Custom vfs::FileSystem is currently used for unit tests. This revision depends on https://reviews.llvm.org/D33397. https://reviews.llvm.org/D33416 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/Clang