Typz updated this revision to Diff 115057.
Typz added a comment.
Split diff: handle only statements in here, namespace macros will be moved to
another one.
https://reviews.llvm.org/D33440
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
Typz updated this revision to Diff 115054.
Typz marked 2 inline comments as done.
Typz added a comment.
Fix review comments, before splitting the commit.
https://reviews.llvm.org/D33440
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
Typz marked 8 inline comments as done.
Typz added inline comments.
Comment at: lib/Format/NamespaceEndCommentsFixer.cpp:155
const FormatToken *NamespaceTok = AnnotatedLines[StartLineIndex]->First;
- // Detect "(inline)? namespace" in the beginning of a line.
- if
krasimir added a comment.
Patch looks good, but I also would like to see it splited. I would suggest to
first get the statement macro part in, which requires less code. Then we can
put the namespace macros on top of that. I really like the generality of this
approach and would want to also add
djasper added a comment.
I'd still prefer individual patches for each of these changes. If the code
review system or VCS make it hard for you to deal with two adjacent changes
this way, do them in sequence.
Adding Manuel as a reviewer who has a longer term idea on how to handle macros.
Typz updated this revision to Diff 114783.
Typz added a comment.
Rebase to master to fix merge issue
https://reviews.llvm.org/D33440
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/FormatTokenLexer.cpp
lib/Format/FormatTokenLexer.h
Typz added a comment.
ping?
https://reviews.llvm.org/D33440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
t>>! In https://reviews.llvm.org/D33440#812645, @djasper wrote:
> So, there are two things in this patch: Statement macros and namespace
> macros. Lets break this out and handle them individually. They really aren't
> related that much.
Indeed, the only "relation" is the
djasper added a comment.
So, there are two things in this patch: Statement macros and namespace macros.
Lets break this out and handle them individually. They really aren't related
that much.
Statement macros:
I think clang-format's handling here is good enough. clang-format does not
insert
Typz added a comment.
ping?
https://reviews.llvm.org/D33440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping?
https://reviews.llvm.org/D33440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping?
https://reviews.llvm.org/D33440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz updated this revision to Diff 103937.
Typz added a comment.
Fix typo
https://reviews.llvm.org/D33440
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/FormatTokenLexer.cpp
lib/Format/FormatTokenLexer.h
13 matches
Mail list logo
