[PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

2017-12-06 Thread Guilherme Amadio via Phabricator via cfe-commits
amadio added a comment. The problems fixed here also happen when compiling with Clang-5.0 and C++17 enabled. What happens is that the assignment to `ProfileFileName` needs a conversion of `PGOTestProfileFile` from the `opt` type to `std::string`, but the compiler is trying to use a deleted cons

[PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

2017-06-13 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. Waiting on resolution to: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79162 Repository: rL LLVM https://reviews.llvm.org/D33467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

2017-06-09 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. This is a libstdc++ bug: https://gcc.gnu.org/PR79162 (They implemented a speculative fix for a different issue and ended up breaking this case.) I think for now we should say we don't support building LLVM with libstdc++7.1 in C++17 mode. Repository: rL LLVM https:/

[PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

2017-06-09 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: rsmith. v.g.vassilev added a comment. @rsmith, what's the right way to proceed here? Repository: rL LLVM https://reviews.llvm.org/D33467 ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

2017-05-26 Thread Richard Smith via cfe-commits
This definitely looks like a GCC bug. On 26 May 2017 1:34 am, "David Abdurachmanov via Phabricator via cfe-commits" wrote: davidlt added a comment. This happens with recent GCC 7.1.1 (updated yesterday) and if compiled in C++1z mode. FAILED: /home/davidlt/root_patch_check/a/slc7_ppc64le_gcc7

Re: [PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

2017-05-26 Thread David Abdurachmanov via cfe-commits
Just reminder that this is in C++1z (C++17) mode, which I doubt is being widely used at this point. I was a change a few months ago that caused it, but cannot recall exact commit in GCC. david > On 26 May 2017, at 10:43, Chandler Carruth wrote: > > I kind of think this may be a GCC bug. It i

Re: [PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

2017-05-26 Thread Chandler Carruth via cfe-commits
Maybe Richard would be a better one to explain what on earth is going on here then... On Fri, May 26, 2017 at 1:51 AM David Abdurachmanov < david.abdurachma...@gmail.com> wrote: > Just reminder that this is in C++1z (C++17) mode, which I doubt is being > widely used at this point. > > I was a cha

Re: [PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

2017-05-26 Thread Chandler Carruth via cfe-commits
I kind of think this may be a GCC bug. It is quite strange that no one else has reported it, and that you're only seeing it in this context. We have many std::string flags and they are used in this way pretty commonly. I'm not seeing this with any other GCC-hosted build bot either, including a PPC

[PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

2017-05-26 Thread David Abdurachmanov via Phabricator via cfe-commits
davidlt added a comment. This happens with recent GCC 7.1.1 (updated yesterday) and if compiled in C++1z mode. FAILED: /home/davidlt/root_patch_check/a/slc7_ppc64le_gcc700/external/gcc/7.0.0-njopjo2/bin/g++ -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -

[PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

2017-05-23 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a subscriber: davidlt. v.g.vassilev added a comment. Adding David in the loop. Repository: rL LLVM https://reviews.llvm.org/D33467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

2017-05-23 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc added a comment. What error are you trying to fix? We use flags without `.getValue()` all over the place, I don't know why we would need to change that here. Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:173 EnablePGOInstrGen = RunPGOInstrGen; -PGOIn

[PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

2017-05-23 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev created this revision. Herald added a subscriber: mehdi_amini. Recent changes within GCC 7 libstdc++ caused build errors inside embedded LLVM. Patch by David Abdurachmanov! Repository: rL LLVM https://reviews.llvm.org/D33467 Files: lib/Transforms/IPO/PassManagerBuilder.cpp