[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

2017-10-10 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 118437. bader added a comment. Applied comments. https://reviews.llvm.org/D33681 Files: lib/Parse/ParseDecl.cpp lib/Sema/SemaType.cpp test/SemaOpenCL/func.cl test/SemaOpenCL/invalid-pipes-cl2.0.cl Index: test/SemaOpenCL/invalid-pipes-cl2.0.cl

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

2017-10-10 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. https://reviews.llvm.org/D33681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

2017-10-10 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. I would prefer to merge the new test with test/SemaOpenCL/func.cl, but otherwise LGTM! Thanks! https://reviews.llvm.org/D33681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

2017-10-09 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 118210. bader edited the summary of this revision. bader added a comment. Fix parsing of function declarations with empty parameter list initializers. This change should fix the failure caught by the buildbot. Sorry for the long delay.

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

2017-06-29 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. @chapuni, thanks for taking care of this. I'll take a look. https://reviews.llvm.org/D33681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

2017-06-29 Thread NAKAMURA Takumi via Phabricator via cfe-commits
chapuni reopened this revision. chapuni added a comment. This revision is now accepted and ready to land. Reverted in https://reviews.llvm.org/rL306660. See also; http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/4926 https://reviews.llvm.org/D33681

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

2017-06-28 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. Sure, no problem! We might add some note on this feature to Clang manual. But we can do it later as well. Thanks! https://reviews.llvm.org/D33681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

2017-06-23 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. Ping. Although this patch is already accepted, I'd like to confirm that I can commit the latest update with changes in test/SemaOpenCL/invalid-pipes-cl2.0.cl. Thanks. https://reviews.llvm.org/D33681 ___ cfe-commits mailing