[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

This revision was automatically updated to reflect the committed changes. Closed by commit rL307175: [Sema] Don't allow -Wunguarded-availability to be silenced with redecls (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D33816?vs=104437&id=105296#toc Repository: rL LL

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. One last comment below: Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2880 InGroup; def note_partial_availability_silence : Note< + "annotate %0 with

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

erik.pilkington updated this revision to Diff 104437. erik.pilkington added a comment. Improve diagnostics for unnamed types. https://reviews.llvm.org/D33816 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/DelayedDiagnostic.h include/clang/Sema/Sema.h lib/Sema/Delay

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

arphaman added inline comments. Comment at: test/SemaObjC/unguarded-availability.m:243 + + struct { new_int mem; } anon; // expected-warning{{'new_int' is partial}} expected-note{{annotate '' with an availability attribute}} +}; We should never have something l

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

erik.pilkington updated this revision to Diff 103958. erik.pilkington added a comment. Make the diagnostic reference the context declaration instead of the offending decl if no enclosing decl is found, fixing the diagnostic bug @arphaman pointed out. https://reviews.llvm.org/D33816 Files: i

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

arphaman added a comment. I don't think the new warning is ideal, e.g.: #import __attribute__((visibility("default"))) __attribute__((availability(macosx,introduced=10_10))) @interface Test : NSObject @end Test *testVar; E.g.: test.m:13:1: warning: 'Test' is partial: intr

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

erik.pilkington updated this revision to Diff 103852. erik.pilkington added a comment. Improve enum diagnostics, as @arphaman suggested. This causes a bit of churn throughout the availability diagnostic machinery, if it would make it at all easier to review, I would be happy to separate out thes

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

arphaman added a comment. I find the change to the diagnostic for enum constants a bit off putting, since the warning can refer to the enum itself when an enum constant is used. I'd rather we say something like `'EnumConstant' is deprecated` and keep the note that this patch uses (`'Enum' has b

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

erik.pilkington added a comment. Ping! https://reviews.llvm.org/D33816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

erik.pilkington created this revision. This patch drops support for suppressing -Wunguarded-availability with redeclarations. This was behavior left over from the -Wpartial-availability days, where it was the only way of silencing the diagnostic. Now that we have @available and better support f