mehdi_amini added inline comments.
Comment at: cfe/trunk/lib/CodeGen/CodeGenModule.cpp:3759
+ unsigned AddrSpace =
+ VD ? GetGlobalVarAddressSpace(VD) : MaterializedType.getAddressSpace();
+ auto TargetAS = getContext().getTargetAddressSpace(AddrSpace);
Co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307470: CodeGen: Fix address space of global variable
(authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D33842?vs=105644&id=105770#toc
Repository:
rL LLVM
https://reviews.llvm.
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Great, thanks! LGTM.
https://reviews.llvm.org/D33842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
yaxunl updated this revision to Diff 105644.
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D33842
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/Targets.cpp
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGDecl.cpp
lib/C
yaxunl marked 4 inline comments as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1144
+ ? CGM.getNSConcreteGlobalBlock()
+ : CGM.getNullPointer(CGM.VoidPtrPtrTy,
+ QualType(CGM.getCont
rjmccall added a comment.
Looks great, thanks! Just a few minor changes.
Comment at: lib/CodeGen/CGBlocks.cpp:1144
+ ? CGM.getNSConcreteGlobalBlock()
+ : CGM.getNullPointer(CGM.VoidPtrPtrTy,
+ QualType(CGM.ge
yaxunl updated this revision to Diff 105310.
yaxunl marked 6 inline comments as done.
yaxunl retitled this revision from "[AMDGPU] Fix address space of global
variable" to "CodeGen: Fix address space of global variable".
yaxunl edited the summary of this revision.
yaxunl added a comment.
Revised
