[PATCH] D34107: [clangd] Allow to override contents of the file during completion.

2017-06-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305280: [clangd] Allow to override contents of the file during completion. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D34107?vs=102300=102301#toc Repository: rL LLVM

[PATCH] D34107: [clangd] Allow to override contents of the file during completion.

2017-06-13 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: unittests/clangd/ClangdTests.cpp:452 + StringRef(OverridenSourceContents)) +.Value; +EXPECT_TRUE(ContainsItem(CodeCompletionResultsOverriden, "cbc")); krasimir wrote: > Is

[PATCH] D34107: [clangd] Allow to override contents of the file during completion.

2017-06-13 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 102300. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. Fixed formatting, added a space (see krasimir's comment) https://reviews.llvm.org/D34107 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h

[PATCH] D34107: [clangd] Allow to override contents of the file during completion.

2017-06-12 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir accepted this revision. krasimir added inline comments. This revision is now accepted and ready to land. Comment at: unittests/clangd/ClangdTests.cpp:432 + // size the same. + // We complete on the 3rd line(2nd in zero-based numbering), because raw + // string

[PATCH] D34107: [clangd] Allow to override contents of the file during completion.

2017-06-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. https://reviews.llvm.org/D34107 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h unittests/clangd/ClangdTests.cpp Index: unittests/clangd/ClangdTests.cpp === ---