This revision was automatically updated to reflect the committed changes.
Closed by commit rL305896: [analyzer] LocalizationChecker: Support new
localizable APIs. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D34266?vs=102771=103347#toc
Repository:
rL LLVM
zaks.anna added a comment.
> Hmm, should there be new tests that demonstrate that we cover the new APIs?
Unless we use a new registration mechanism for some of these APIs, I'd be fine
without adding a test for every API that has localization constraints.
Repository:
rL LLVM
NoQ added a comment.
Hmm, should there be new tests that demonstrate that we cover the new APIs?
Repository:
rL LLVM
https://reviews.llvm.org/D34266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kulpreet added a comment.
In https://reviews.llvm.org/D34266#783156, @zaks.anna wrote:
> Thanks! Do you have commit access?
No problem! I don’t have commit access. In the past, Devin has commited on my
behalf.
Repository:
rL LLVM
https://reviews.llvm.org/D34266
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thanks! Do you have commit access?
Repository:
rL LLVM
https://reviews.llvm.org/D34266
___
cfe-commits mailing list
kulpreet created this revision.
- Added in new iOS and macOS APIs that require a localized string
- Ran unit tests
Repository:
rL LLVM
https://reviews.llvm.org/D34266
Files:
lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp
Index: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp
