This revision was automatically updated to reflect the committed changes.
Closed by commit rL308528: Rework libcxx strerror_r handling. (authored by
jyknight).
Repository:
rL LLVM
https://reviews.llvm.org/D34294
Files:
libcxx/trunk/src/system_error.cpp
Index:
jyknight added a comment.
EricWF, wdyt?
https://reviews.llvm.org/D34294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krytarowski added a comment.
In https://reviews.llvm.org/D34294#782856, @jyknight wrote:
> In https://reviews.llvm.org/D34294#782806, @krytarowski wrote:
>
> > New one is harder to comprehend and less portable (usage of `__atribute__`).
>
>
> I can't disagree more strongly. This is
jyknight added a comment.
In https://reviews.llvm.org/D34294#782806, @krytarowski wrote:
> New one is harder to comprehend and less portable (usage of `__atribute__`).
I can't disagree more strongly. This is fundamentally portable C++ code --
__attribute__((unused)) is simply warning
krytarowski added a comment.
Or better:
#elif __GLIBC__ || (__ANDROID_API__ - 0) >= 23
If I understand correctly, Android adopted GNU version.
https://reviews.llvm.org/D34294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
krytarowski added a comment.
New one is harder to comprehend and less portable (usage of `__atribute__`).
Can we just replace
#elif defined(__linux__) && !defined(_LIBCPP_HAS_MUSL_LIBC) &&
\
(!defined(__ANDROID__) || __ANDROID_API__ >= 23)
with `#elif __GLIBC__`?
jyknight created this revision.
Herald added subscribers: krytarowski, srhines.
The set of #ifdefs used to handle the two incompatible variants of
strerror_r were not complete (they didn't handle newlib appropriately).
Rather than attempting to make the ifdefs more complex, make them
unnecessary
